* Re: [PATCH] scripts/Kbuild.include: Fix portability problem of "echo -e" [not found] <1330277718-2667-1-git-send-email-bernhard@bwalle.de> @ 2012-02-26 17:48 ` Sam Ravnborg 2012-02-26 17:51 ` Bernhard Walle 0 siblings, 1 reply; 5+ messages in thread From: Sam Ravnborg @ 2012-02-26 17:48 UTC (permalink / raw) To: Bernhard Walle; +Cc: mmarek, lacombar, linux-kernel, linux-kbuild On Sun, Feb 26, 2012 at 06:35:18PM +0100, Bernhard Walle wrote: > "echo -e" is a GNU extension. When cross-compiling the kernel on a > BSD-like operating system (Mac OS X in my case), this doesn't work. > > One could install a GNU version of echo, put that in the $PATH before > the system echo and use "/usr/bin/env echo", but the solution with > printf is simpler. > > Since it is no disadvantage on Linux, I hope that gets accepted even if > cross-compiling the Linux kernel on another Unix operating system is > quite a rare use case. > > Signed-off-by: Bernhard Walle <bernhard@bwalle.de> > --- > scripts/Kbuild.include | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include > index d897278..6a3ee98 100644 > --- a/scripts/Kbuild.include > +++ b/scripts/Kbuild.include > @@ -104,7 +104,7 @@ as-option = $(call try-run,\ > # Usage: cflags-y += $(call as-instr,instr,option1,option2) > > as-instr = $(call try-run,\ > - /bin/echo -e "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) > + printf "%b\n" "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) > > # cc-option > # Usage: cflags-y += $(call cc-option,-march=winchip-c6,-march=i586) Roman Zippel removed use of printf in this patch: beda9f3a13bbb22cde92a45f230a02ef2afef6a9 I cannot remember why - but it would be good if you could dig up why - just so we do not hit an old issue again. Sam ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/Kbuild.include: Fix portability problem of "echo -e" 2012-02-26 17:48 ` [PATCH] scripts/Kbuild.include: Fix portability problem of "echo -e" Sam Ravnborg @ 2012-02-26 17:51 ` Bernhard Walle 2012-02-26 21:05 ` Sam Ravnborg 0 siblings, 1 reply; 5+ messages in thread From: Bernhard Walle @ 2012-02-26 17:51 UTC (permalink / raw) To: Sam Ravnborg; +Cc: mmarek, lacombar, linux-kernel, linux-kbuild, zippel Am 26.02.12 18:48, schrieb Sam Ravnborg: >> > --- a/scripts/Kbuild.include >> > +++ b/scripts/Kbuild.include >> > @@ -104,7 +104,7 @@ as-option = $(call try-run,\ >> > # Usage: cflags-y += $(call as-instr,instr,option1,option2) >> > >> > as-instr = $(call try-run,\ >> > - /bin/echo -e "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) >> > + printf "%b\n" "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) >> > >> > # cc-option >> > # Usage: cflags-y += $(call cc-option,-march=winchip-c6,-march=i586) > Roman Zippel removed use of printf in this patch: beda9f3a13bbb22cde92a45f230a02ef2afef6a9 > > I cannot remember why - but it would be good if you could dig up > why - just so we do not hit an old issue again. Well, he used printf "$(1)", that's different from printf "%b\n" "$(1)" since format strings inside $(1) would be interpreted. But maybe Roman can comment on that? Cc'ing him. Regards, Bernhard ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/Kbuild.include: Fix portability problem of "echo -e" 2012-02-26 17:51 ` Bernhard Walle @ 2012-02-26 21:05 ` Sam Ravnborg 2012-03-19 17:44 ` Bernhard Walle 0 siblings, 1 reply; 5+ messages in thread From: Sam Ravnborg @ 2012-02-26 21:05 UTC (permalink / raw) To: Bernhard Walle; +Cc: mmarek, lacombar, linux-kernel, linux-kbuild, zippel On Sun, Feb 26, 2012 at 06:51:34PM +0100, Bernhard Walle wrote: > Am 26.02.12 18:48, schrieb Sam Ravnborg: > >> > --- a/scripts/Kbuild.include > >> > +++ b/scripts/Kbuild.include > >> > @@ -104,7 +104,7 @@ as-option = $(call try-run,\ > >> > # Usage: cflags-y += $(call as-instr,instr,option1,option2) > >> > > >> > as-instr = $(call try-run,\ > >> > - /bin/echo -e "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) > >> > + printf "%b\n" "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) > >> > > >> > # cc-option > >> > # Usage: cflags-y += $(call cc-option,-march=winchip-c6,-march=i586) > > Roman Zippel removed use of printf in this patch: beda9f3a13bbb22cde92a45f230a02ef2afef6a9 > > > > I cannot remember why - but it would be good if you could dig up > > why - just so we do not hit an old issue again. > > Well, he used printf "$(1)", that's different from printf "%b\n" "$(1)" > since format strings inside $(1) would be interpreted. Makes good sense. > > But maybe Roman can comment on that? Cc'ing him. Would be good to hear from Roman - but he has been MIA for some years now :-( Sam ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/Kbuild.include: Fix portability problem of "echo -e" 2012-02-26 21:05 ` Sam Ravnborg @ 2012-03-19 17:44 ` Bernhard Walle 2012-03-24 22:33 ` Michal Marek 0 siblings, 1 reply; 5+ messages in thread From: Bernhard Walle @ 2012-03-19 17:44 UTC (permalink / raw) To: Sam Ravnborg; +Cc: mmarek, lacombar, linux-kernel, linux-kbuild, zippel Am 26.02.12 22:05, schrieb Sam Ravnborg: > On Sun, Feb 26, 2012 at 06:51:34PM +0100, Bernhard Walle wrote: >> Am 26.02.12 18:48, schrieb Sam Ravnborg: >>>>> --- a/scripts/Kbuild.include >>>>> +++ b/scripts/Kbuild.include >>>>> @@ -104,7 +104,7 @@ as-option = $(call try-run,\ >>>>> # Usage: cflags-y += $(call as-instr,instr,option1,option2) >>>>> >>>>> as-instr = $(call try-run,\ >>>>> - /bin/echo -e "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) >>>>> + printf "%b\n" "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) >>>>> >>>>> # cc-option >>>>> # Usage: cflags-y += $(call cc-option,-march=winchip-c6,-march=i586) >>> Roman Zippel removed use of printf in this patch: beda9f3a13bbb22cde92a45f230a02ef2afef6a9 >>> >>> I cannot remember why - but it would be good if you could dig up >>> why - just so we do not hit an old issue again. >> >> Well, he used printf "$(1)", that's different from printf "%b\n" "$(1)" >> since format strings inside $(1) would be interpreted. > Makes good sense. Can we merge that for 3.4? Who is responsible, i.e. whose tree? Regards, Bernhard ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scripts/Kbuild.include: Fix portability problem of "echo -e" 2012-03-19 17:44 ` Bernhard Walle @ 2012-03-24 22:33 ` Michal Marek 0 siblings, 0 replies; 5+ messages in thread From: Michal Marek @ 2012-03-24 22:33 UTC (permalink / raw) To: Bernhard Walle; +Cc: Sam Ravnborg, lacombar, linux-kernel, linux-kbuild, zippel On Mon, Mar 19, 2012 at 06:44:20PM +0100, Bernhard Walle wrote: > Am 26.02.12 22:05, schrieb Sam Ravnborg: > > On Sun, Feb 26, 2012 at 06:51:34PM +0100, Bernhard Walle wrote: > >> Am 26.02.12 18:48, schrieb Sam Ravnborg: > >>>>> --- a/scripts/Kbuild.include > >>>>> +++ b/scripts/Kbuild.include > >>>>> @@ -104,7 +104,7 @@ as-option = $(call try-run,\ > >>>>> # Usage: cflags-y += $(call as-instr,instr,option1,option2) > >>>>> > >>>>> as-instr = $(call try-run,\ > >>>>> - /bin/echo -e "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) > >>>>> + printf "%b\n" "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) > >>>>> > >>>>> # cc-option > >>>>> # Usage: cflags-y += $(call cc-option,-march=winchip-c6,-march=i586) > >>> Roman Zippel removed use of printf in this patch: beda9f3a13bbb22cde92a45f230a02ef2afef6a9 > >>> > >>> I cannot remember why - but it would be good if you could dig up > >>> why - just so we do not hit an old issue again. > >> > >> Well, he used printf "$(1)", that's different from printf "%b\n" "$(1)" > >> since format strings inside $(1) would be interpreted. > > Makes good sense. > > Can we merge that for 3.4? Who is responsible, i.e. whose tree? I merged it to kbuild.git#kbuild now. Michal ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-24 22:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1330277718-2667-1-git-send-email-bernhard@bwalle.de>
2012-02-26 17:48 ` [PATCH] scripts/Kbuild.include: Fix portability problem of "echo -e" Sam Ravnborg
2012-02-26 17:51 ` Bernhard Walle
2012-02-26 21:05 ` Sam Ravnborg
2012-03-19 17:44 ` Bernhard Walle
2012-03-24 22:33 ` Michal Marek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox