From: Grzegorz Nosek <root@localdomain.pl>
To: linux-kbuild@vger.kernel.org
Cc: Asbjoern Sloth Toennesen <asbjorn@asbjorn.biz>,
maximilian attems <max@stro.at>, Michal Marek <mmarek@suse.cz>,
root@localdomain.pl
Subject: [PATCH v2] Don't force deb architecture on universal packages
Date: Fri, 23 Mar 2012 15:59:35 +0100 [thread overview]
Message-ID: <4F6C8FD7.70901@localdomain.pl> (raw)
$debarch is basically always set so the Architecture field from
debian/control is ignored. While we don't really care for most packages
(they have Architecture: any or some specific $arch), this breaks the
firmware package as it becomes an arch-dependent .deb, ignoring its
Architecture: all entry.
It's apparently broken by 10f26fa64200095af0e5d80a980e47877865e4b7.
Signed-off-by: Grzegorz Nosek <root@localdomain.pl>
---
Note: this is based on 3.2 as that's what I'm currently using. I'll
rebase onto whatever is required when the general idea is accepted.
(earlier version was completely bogus, sorry for that)
Best regards,
Grzegorz Nosek
scripts/package/builddeb | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 3c6c0b1..43476c5 100644
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -57,8 +57,11 @@ create_package() {
if [ -n "$KBUILD_DEBARCH" ] ; then
debarch="$KBUILD_DEBARCH"
fi
- if [ -n "$debarch" ] ; then
- forcearch="-DArchitecture=$debarch"
+ if [ -n "$debarch" ]; then
+ pkgarch=`sed -n "/^Package: $pname\$/,/^\$/s/^Architecture: //p" debian/control`
+ if [ "$pkgarch" != "all" ]; then
+ forcearch="-DArchitecture=$debarch"
+ fi
fi
# Create the package
--
1.7.2.3
reply other threads:[~2012-03-23 14:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6C8FD7.70901@localdomain.pl \
--to=root@localdomain.pl \
--cc=asbjorn@asbjorn.biz \
--cc=linux-kbuild@vger.kernel.org \
--cc=max@stro.at \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox