public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] Don't force deb architecture on universal packages
@ 2012-03-23 14:59 Grzegorz Nosek
  0 siblings, 0 replies; only message in thread
From: Grzegorz Nosek @ 2012-03-23 14:59 UTC (permalink / raw)
  To: linux-kbuild
  Cc: Asbjoern Sloth Toennesen, maximilian attems, Michal Marek, root

$debarch is basically always set so the Architecture field from
debian/control is ignored. While we don't really care for most packages
(they have Architecture: any or some specific $arch), this breaks the
firmware package as it becomes an arch-dependent .deb, ignoring its
Architecture: all entry.

It's apparently broken by 10f26fa64200095af0e5d80a980e47877865e4b7.

Signed-off-by: Grzegorz Nosek <root@localdomain.pl>
---
Note: this is based on 3.2 as that's what I'm currently using. I'll
rebase onto whatever is required when the general idea is accepted.

(earlier version was completely bogus, sorry for that)

Best regards,
 Grzegorz Nosek

 scripts/package/builddeb |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 3c6c0b1..43476c5 100644
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -57,8 +57,11 @@ create_package() {
 	if [ -n "$KBUILD_DEBARCH" ] ; then
 		debarch="$KBUILD_DEBARCH"
 	fi
-	if [ -n "$debarch" ] ; then
-		forcearch="-DArchitecture=$debarch"
+	if [ -n "$debarch" ]; then
+		pkgarch=`sed -n "/^Package: $pname\$/,/^\$/s/^Architecture: //p" debian/control`
+		if [ "$pkgarch" != "all" ]; then
+			forcearch="-DArchitecture=$debarch"
+		fi
 	fi

 	# Create the package
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-03-23 14:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-23 14:59 [PATCH v2] Don't force deb architecture on universal packages Grzegorz Nosek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox