public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Frank Rowand <frank.rowand@am.sony.com>
To: "Rowand, Frank" <Frank_Rowand@sonyusa.com>
Cc: Alessio Igor Bogani <abogani@kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Jan Beulich <jbeulich@novell.com>,
	Kbuild <linux-kbuild@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Bird, Tim" <Tim.Bird@am.sony.com>,
	Anders Kaseorg <andersk@ksplice.com>,
	Arnaud Lacombe <lacombar@gmail.com>
Subject: Re: [PATCH] Let modpost parses vmlinux instead of vmlinux.o
Date: Thu, 29 Mar 2012 14:57:58 -0700	[thread overview]
Message-ID: <4F74DAE6.9000001@am.sony.com> (raw)
In-Reply-To: <4F74D9C3.5010907@am.sony.com>

On 03/29/12 14:53, Frank Rowand wrote:
> On 03/29/12 07:53, Alessio Igor Bogani wrote:
>> Dear Mr. Rowand,
> 
> No need to be formal, "Frank" is ok.
> 
> 
>>
>> What do you think about this patch?
> 
> It does not work for me.  The resulting Module.symvers is empty.
> 
> Before applying the Makefile patch, "make V=1" shows the command
                                      ^^^ "make V=1 vmlinux"
> to generate Module.symvers is:
> 
>   scripts/mod/modpost   -o /a/home/frowand/me/src/linux/kernel-org/build/crest/Module.symvers    -S   vmlinux.o
> 
> after applying the patch, the command becomes:
> 
>   scripts/mod/modpost   -o /a/home/frowand/me/src/linux/kernel-org/build/crest/Module.symvers    -S   -s
> 
> 
> -Frank
> 
>> Thanks!
>>
>> Ciao,
>> Alessio
>>
>> ---
>>  Makefile                 |    2 +-
>>  scripts/Makefile.modpost |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 123d858..b589d1f 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -876,7 +876,7 @@ quiet_cmd_vmlinux-modpost = LD      $@
>>  define rule_vmlinux-modpost
>>  	:
>>  	+$(call cmd,vmlinux-modpost)
>> -	$(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost $@
>> +	$(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost $*
>>  	$(Q)echo 'cmd_$@ := $(cmd_vmlinux-modpost)' > $(dot-target).cmd
>>  endef
>>  
>> diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
>> index 56dfafc..ca0db29 100644
>> --- a/scripts/Makefile.modpost
>> +++ b/scripts/Makefile.modpost
>> @@ -93,7 +93,7 @@ __modpost: $(modules:.ko=.o) FORCE
>>  quiet_cmd_kernel-mod = MODPOST $@
>>        cmd_kernel-mod = $(modpost) $@
>>  
>> -vmlinux.o: FORCE
>> +vmlinux vmlinux.o: FORCE
>>  	$(call cmd,kernel-mod)
>>  
>>  # Declare generated files as targets for modpost
> 
> .
> 



      reply	other threads:[~2012-03-29 21:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4F737193.4030709@am.sony.com>
2012-03-29 14:53 ` [PATCH] Let modpost parses vmlinux instead of vmlinux.o Alessio Igor Bogani
2012-03-29 20:23   ` Sam Ravnborg
2012-03-29 21:53   ` Frank Rowand
2012-03-29 21:57     ` Frank Rowand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F74DAE6.9000001@am.sony.com \
    --to=frank.rowand@am.sony.com \
    --cc=Frank_Rowand@sonyusa.com \
    --cc=Tim.Bird@am.sony.com \
    --cc=abogani@kernel.org \
    --cc=andersk@ksplice.com \
    --cc=jbeulich@novell.com \
    --cc=lacombar@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox