Re: [PATCH 7/8] kbuild: move W=... stuff to Kbuild.arch

[Michal Marek <mmarek@suse.cz>]

On 5.5.2012 10:18, Sam Ravnborg wrote:
> Prevent that we eveluate cc-option multiple times for the same
> option by moving the definitions to Kbuild.arch.
> The file is included once only, thus gcc is not invoked once per directory.

Nice.


> Another side-effect of this patch is that KCFLAGS are appended last
> to the list of options. This allows us to better control the options.
> Artem Bityutskiy <dedekind1@gmail.com> noticed this.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Artem Bityutskiy <dedekind1@gmail.com>
> ---
>  scripts/Kbuild.arch    |   51 +++++++++++++++++++++++++++++++++++++++++++++++-
>  scripts/Makefile.build |   51 ------------------------------------------------
>  2 files changed, 50 insertions(+), 52 deletions(-)
> 
> diff --git a/scripts/Kbuild.arch b/scripts/Kbuild.arch
> index 230050f..6ff27c6 100644
> --- a/scripts/Kbuild.arch
> +++ b/scripts/Kbuild.arch
> @@ -76,6 +76,56 @@ ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y)
>          KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO
>  endif
>  
> +# make W=... settings

Again a nitpick only, in the comment earlier in this file

# This warning generated too much noise in a regular build.
# Use make W=1 to enable this warning (see scripts/Makefile.build)

the scripts/Makefile.build reference lost its meaning now.

Michal