From: Michal Marek <mmarek@suse.cz>
To: pefoley2@verizon.net, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 3/5] add eboot.o and efi_stub_$(BITS).o to $(targets)
Date: Sun, 09 Dec 2012 17:35:37 +0100 [thread overview]
Message-ID: <50C4BDD9.6030806@suse.cz> (raw)
In-Reply-To: <1353269117-39917-3-git-send-email-pefoley2@verizon.net>
Added x86@kernel.org.
On 18.11.2012 21:05, pefoley2@verizon.net wrote:
> From: Peter Foley <pefoley2@verizon.net>
>
> eboot.o and efi_stub_$(BITS).o are not in $(targets) so they are rebuilt
> every time make is invoked. Add them to $(targets) to prevent unnecessary
> rebuilding of bzImage.
>
> Signed-off-by: Peter Foley <pefoley2@verizon.net>
Acked-by: Michal Marek <mmarek@suse.cz>
BTW, it might be a good idea to split the $(targets) assignment into
multiple lines.
Michal
> ---
> arch/x86/boot/compressed/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
> index 8a84501..9d7a898 100644
> --- a/arch/x86/boot/compressed/Makefile
> +++ b/arch/x86/boot/compressed/Makefile
> @@ -4,7 +4,7 @@
> # create a compressed vmlinux image from the original vmlinux
> #
>
> -targets := vmlinux.lds vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 vmlinux.bin.lzma vmlinux.bin.xz vmlinux.bin.lzo head_$(BITS).o misc.o string.o cmdline.o early_serial_console.o piggy.o
> +targets := vmlinux.lds vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 vmlinux.bin.lzma vmlinux.bin.xz vmlinux.bin.lzo head_$(BITS).o misc.o string.o cmdline.o early_serial_console.o piggy.o eboot.o efi_stub_$(BITS).o
>
> KBUILD_CFLAGS := -m$(BITS) -D__KERNEL__ $(LINUX_INCLUDE) -O2
> KBUILD_CFLAGS += -fno-strict-aliasing -fPIC
>
next prev parent reply other threads:[~2012-12-09 16:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 20:05 [PATCH 1/5] kbuild: remove deprecated use of defined in timeconst.pl pefoley2
2012-11-18 20:05 ` [PATCH 2/5] kbuild: silence rule for extra_certificates pefoley2
2012-12-09 16:54 ` Michal Marek
2012-12-10 0:08 ` Rusty Russell
2012-12-11 1:18 ` Peter Foley
2012-11-18 20:05 ` [PATCH 3/5] add eboot.o and efi_stub_$(BITS).o to $(targets) pefoley2
2012-12-09 16:35 ` Michal Marek [this message]
2012-11-18 20:05 ` [PATCH 4/5] silence 'arch/x86/realmode/rm/realmode.bin' is up to date message pefoley2
2012-12-09 16:37 ` Michal Marek
2012-11-18 20:05 ` [PATCH 5/5] x86: add dummy rules to avoid 'nothing to be done' messages pefoley2
2012-12-09 16:37 ` Michal Marek
2012-12-09 16:57 ` [PATCH 1/5] kbuild: remove deprecated use of defined in timeconst.pl Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C4BDD9.6030806@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pefoley2@verizon.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).