* [PATCH] Makefile: Make checkstack work with O= builds
@ 2012-12-22 1:58 Stephen Boyd
2013-01-13 22:02 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Boyd @ 2012-12-22 1:58 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-kernel, linux-arm-msm, linux-kbuild
The vmlinux doesn't always live in the same directory as the
source files and so 'make O=obj checkstack' fails with a missing
vmlinux file. Fix checkstack so that this is possible.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
It would also be nice if this depended on vmlinux and modules being built
already but I couldn't figure that part out.
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 4fe0559..54a386b 100644
--- a/Makefile
+++ b/Makefile
@@ -1318,7 +1318,7 @@ else
CHECKSTACK_ARCH := $(ARCH)
endif
checkstack:
- $(OBJDUMP) -d vmlinux $$(find . -name '*.ko') | \
+ $(OBJDUMP) -d $(objtree)/vmlinux $$(find $(objtree) -name '*.ko') | \
$(PERL) $(src)/scripts/checkstack.pl $(CHECKSTACK_ARCH)
kernelrelease:
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Makefile: Make checkstack work with O= builds
2012-12-22 1:58 [PATCH] Makefile: Make checkstack work with O= builds Stephen Boyd
@ 2013-01-13 22:02 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2013-01-13 22:02 UTC (permalink / raw)
To: Stephen Boyd; +Cc: linux-kernel, linux-arm-msm, linux-kbuild
On 22.12.2012 02:58, Stephen Boyd wrote:
> The vmlinux doesn't always live in the same directory as the
> source files and so 'make O=obj checkstack' fails with a missing
> vmlinux file. Fix checkstack so that this is possible.
It works for me even without your patch. With O=<dir>, a second make is
run in <dir>, so $(objtree) is equivalent to . for the top-level
Makefile. Can you post the exact command your run and the error message
you get?
Thanks,
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-13 22:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-22 1:58 [PATCH] Makefile: Make checkstack work with O= builds Stephen Boyd
2013-01-13 22:02 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).