From: Casey Schaufler <casey@schaufler-ca.com>
To: winton <newtonliuwen@gmail.com>
Cc: james.l.morris@oracle.com, linux-security-module@vger.kernel.org,
linux-kbuild@vger.kernel.org
Subject: Re: Security Kconfig is not common
Date: Wed, 23 Jan 2013 08:30:34 -0800 [thread overview]
Message-ID: <5100102A.6020009@schaufler-ca.com> (raw)
In-Reply-To: <50FFE587.4020801@gmail.com>
On 1/23/2013 5:28 AM, winton wrote:
> Hi James,
>
> Please help to review this patch.
> When I analysis Kconfig files, I searched the keywork "source" and
> then follow double quotations. The Kconfig in security is missing.
> That's because security/Kconfig source keyword didn't using double
> quotations.
> Although that's may be not necessary. But I think the same as
> other Kconfig files will be better.
>
> Best regards,
> Winton.Liu
The practice of quoting the source pathnames is usual, but far from
universal. There are several examples in the arch and drivers directories.
If you believe this is significant, see if the checkpatch maintainer is
interested in adding a check.
next prev parent reply other threads:[~2013-01-23 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 13:28 Security Kconfig is not common winton
2013-01-23 16:30 ` Casey Schaufler [this message]
2013-01-24 10:26 ` winton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5100102A.6020009@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=james.l.morris@oracle.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=newtonliuwen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox