Re: Security Kconfig is not common

[winton <newtonliuwen@gmail.com>]

On 01/24/2013 12:30 AM, Casey Schaufler wrote:
> On 1/23/2013 5:28 AM, winton wrote:
>> Hi James,
>>
>>      Please help to review this patch.
>>      When I analysis Kconfig files, I searched the keywork "source" and
>> then follow double quotations. The Kconfig in security is missing.
>> That's because security/Kconfig source keyword didn't using double
>> quotations.
>>      Although that's may be not necessary. But I think the same as
>> other Kconfig files will be better.
>>
>> Best regards,
>> Winton.Liu
> The practice of quoting the source pathnames is usual, but far from
> universal. There are several examples in the arch and drivers directories.
> If you believe this is significant, see if the checkpatch maintainer is
> interested in adding a check.
>
>
Dear Casey,

     Thank you for your explanations. Indeed that's now universal right now.
     That's the result I calculate (from the newest kenerl) :
     Only 9 Kconfig doesn't contains quotations as belowing:
./arch/cris/arch-v32/Kconfig
./arch/cris/arch-v32/drivers/Kconfig
./security/integrity/Kconfig
./security/Kconfig
./drivers/crypto/Kconfig
./drivers/pps/Kconfig
./drivers/hwmon/Kconfig
./drivers/i2c/Kconfig
./drivers/w1/Kconfig
There are 967 Kconfig in kernel
There are 159 Kconfig containning source keyword

     I hope that would be universal one day. Just 9, not so much.

Best regards,
Winton.Liu