From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:60574 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604Ab3AaKhk (ORCPT ); Thu, 31 Jan 2013 05:37:40 -0500 Message-ID: <510A4967.5070009@suse.cz> Date: Thu, 31 Jan 2013 11:37:27 +0100 From: Michal Marek MIME-Version: 1.0 Subject: Re: [PATCH 1/1] depmod: pass -P $CONFIG_SYMBOL_PREFIX References: <1359625303-11842-1-git-send-email-james.hogan@imgtec.com> In-Reply-To: <1359625303-11842-1-git-send-email-james.hogan@imgtec.com> Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: James Hogan Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Mike Frysinger , Yoshinori Sato , uclinux-dist-devel@blackfin.uclinux.org On 31.1.2013 10:41, James Hogan wrote: > On architectures which have symbol prefixes, depmod emits lots of false > warnings like this: > > WARNING: $module.ko needs unknown symbol $symbol > > This is because depmod isn't being passed the -P > arguments to specify the symbol prefix to ignore. This option is > included since the 3.13 release of module-init-tools. > > Update scripts/depmod.sh to take extra arguments which are passed > through directly to depmod, and update the main Makefile to pass > -P $(CONFIG_SYMBOL_PREFIX to scripts/depmod.sh, but only if > CONFIG_SYMBOL_PREFIX is set and non-empty. OK. > scripts/depmod.sh also drops the -P arguments if depmod --version > reports module-init-tools with a version number < 3.13. You can replace the test with a simple "$DEPMOD" -P _ --help 2>/dev/null >/dev/null Michal