Re: [RFC][PATCH] kernel: Replace timeconst.pl with a bc script

Michal Marek
2013-02-16T22:04:11Z

Dne 16.2.2013 00:44, H. Peter Anvin napsal(a):
> On 02/15/2013 03:41 PM, Michal Marek wrote:
>> I can merge it into the kbuild tree if wanted. I only have one nipick:
>>
>>> +/* Division by reciprocal multiplication. */
>>> +define fmul(b,n,d) {
>>> + return (2^b*n+d-1)/d;
>>> +}
>>
>> For readability reasons, I suggest to use the same formatting of
>> expressions and argument lists like in C:
>>
>> define fmul(b, n, d) {
>> return (2^b * n + d - 1) / d;
>> }
>>
>> Otherwise, you can add
>>
>
> Do you actually think that is more readable? Personally, I think it
> made it harder to read just because it takes up more space than one can
> quickly glance at.

I personally find the wider version more readable, but I don't care that
much.

Michal