From: Michal Marek <mmarek@suse.cz>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kbuild@vger.kernel.org, mingo@kernel.org,
tglx@linutronix.de, Andrew Morton <akpm@linux-foundation.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [RFC][PATCH] kernel: Replace timeconst.pl with a bc script
Date: Sat, 16 Feb 2013 23:03:55 +0100 [thread overview]
Message-ID: <5120024B.7070800@suse.cz> (raw)
In-Reply-To: <511EC849.6030400@zytor.com>
Dne 16.2.2013 00:44, H. Peter Anvin napsal(a):
> On 02/15/2013 03:41 PM, Michal Marek wrote:
>> I can merge it into the kbuild tree if wanted. I only have one nipick:
>>
>>> +/* Division by reciprocal multiplication. */
>>> +define fmul(b,n,d) {
>>> + return (2^b*n+d-1)/d;
>>> +}
>>
>> For readability reasons, I suggest to use the same formatting of
>> expressions and argument lists like in C:
>>
>> define fmul(b, n, d) {
>> return (2^b * n + d - 1) / d;
>> }
>>
>> Otherwise, you can add
>>
>
> Do you actually think that is more readable? Personally, I think it
> made it harder to read just because it takes up more space than one can
> quickly glance at.
I personally find the wider version more readable, but I don't care that
much.
Michal
next prev parent reply other threads:[~2013-02-16 22:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 23:13 [RFC][PATCH] kernel: Replace timeconst.pl with a bc script H. Peter Anvin
2013-02-15 12:01 ` Sam Ravnborg
2013-02-15 23:41 ` Michal Marek
2013-02-15 23:44 ` H. Peter Anvin
2013-02-16 22:03 ` Michal Marek [this message]
2013-02-16 22:10 ` H. Peter Anvin
2013-02-16 22:50 ` Michal Marek
2013-02-16 1:00 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5120024B.7070800@suse.cz \
--to=mmarek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox