public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: linux-kbuild@vger.kernel.org, Justin Lecher <jlec@gentoo.org>
Subject: Re: [PATCH 1/2] menuconfig: optionally use pkg-config to detect ncurses libs
Date: Thu, 21 Mar 2013 23:09:35 +0100	[thread overview]
Message-ID: <514B851F.4010500@suse.cz> (raw)
In-Reply-To: <fc9c6e000f62c2eeda426d4d5f022b3d57729bb0.1362679061.git.yann.morin.1998@free.fr>

Dne 7.3.2013 19:20, Yann E. MORIN napsal(a):
> From: Justin Lecher <jlec@gentoo.org>
> 
> When building ncurses with --with-termlib several symbols get moved from
> libncurses.so to libtinfo.so. Thus when linking with libncurses.so, one
> additionally needs to link with libtinfo.so.
> 
> The ncurses pkg-config module will be used to detect the necessary libs for
> linking. If not available the old heuristic for detection of the ncurses libs
> will be used.
> 
> Signed-off-by: Justin Lecher <jlec@gentoo.org>
> Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  scripts/kconfig/lxdialog/check-lxdialog.sh |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
> index 8078813..782d200 100644
> --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> @@ -4,6 +4,8 @@
>  # What library to link
>  ldflags()
>  {
> +	pkg-config --libs ncursesw 2>/dev/null && exit
> +	pkg-config --libs ncurses 2>/dev/null && exit
>  	for ext in so a dll.a dylib ; do
>  		for lib in ncursesw ncurses curses ; do

Do you also plan to use pkg-config in the ccflags function?

Thanks,
Michal


  reply	other threads:[~2013-03-21 22:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07 18:20 [pull request] Pull request for branch yem-kconfig-rc-fixes Yann E. MORIN
2013-03-07 18:20 ` [PATCH 1/2] menuconfig: optionally use pkg-config to detect ncurses libs Yann E. MORIN
2013-03-21 22:09   ` Michal Marek [this message]
2013-03-22 18:30     ` Yann E. MORIN
2013-03-07 18:20 ` [PATCH 2/2] kconfig: " Yann E. MORIN
2013-03-18 18:35 ` [pull request] Pull request for branch yem-kconfig-rc-fixes Yann E. MORIN
2013-03-21 22:09   ` Michal Marek
     [not found] <Use config scripts to detect ncurses libs for, menuconfig/nconfig dialogs>
2013-03-06 13:02 ` Final versions of ncurses libs detection patches jlec
2013-03-06 13:02   ` [PATCH 1/2] menuconfig: optionally use pkg-config to detect ncurses libs jlec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514B851F.4010500@suse.cz \
    --to=mmarek@suse.cz \
    --cc=jlec@gentoo.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox