* [pull request] Pull request for branch yem-kconfig-for-next
@ 2013-01-15 23:12 Yann E. MORIN
2013-01-24 10:44 ` Michal Marek
0 siblings, 1 reply; 22+ messages in thread
From: Yann E. MORIN @ 2013-01-15 23:12 UTC (permalink / raw)
To: linux-kbuild; +Cc: Michal Marek, Yann E. MORIN
Hello Michal, All!
These are the kconfig patches I've queued for 3.9.
There are a few more on the list, but they need rework first (the vi- and
readline-like-keys series).
The following changes since commit 87727d453b4677a21312712c8a4bb5dcd81a1ebe:
menuconfig:inputbox: support navigate input position (2012-12-25 23:42:37 +0100)
are available in the git repository at:
git://gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next
Roland Eggner (1):
nconf: function keys line, change background color for better readability
Wang YanQing (2):
menuconfig: Add Save/Load buttons
menuconfig: Get rid of the top-level entries for "Load an Alternate/Save an Alternate"
scripts/kconfig/lxdialog/menubox.c | 20 +++++++++-------
scripts/kconfig/mconf.c | 44 ++++++++++++++++++++---------------
scripts/kconfig/nconf.gui.c | 2 +-
3 files changed, 37 insertions(+), 29 deletions(-)
Regards,
Yann E. MORIN
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [pull request] Pull request for branch yem-kconfig-for-next
2013-01-15 23:12 Yann E. MORIN
@ 2013-01-24 10:44 ` Michal Marek
0 siblings, 0 replies; 22+ messages in thread
From: Michal Marek @ 2013-01-24 10:44 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: linux-kbuild
On 16.1.2013 00:12, Yann E. MORIN wrote:
> Hello Michal, All!
>
> These are the kconfig patches I've queued for 3.9.
Pulled, thanks!
Michal
^ permalink raw reply [flat|nested] 22+ messages in thread
* [pull request] Pull request for branch yem-kconfig-for-next
@ 2013-02-09 0:58 Yann E. MORIN
2013-02-16 11:18 ` Yann E. MORIN
0 siblings, 1 reply; 22+ messages in thread
From: Yann E. MORIN @ 2013-02-09 0:58 UTC (permalink / raw)
To: linux-kbuild; +Cc: Michal Marek, Roland Eggner, Dmitry Voytik, Yann E. MORIN
Hello Michal, All!
This series by Roland, updates the help texts for the nconf frontends, and
brings it from its lingering state to (to my knowledge) an up-to-date and
complete coverage of nconf.
Please apply for 3.9.
The following changes since commit aed9934bf182c049d966bd106ad7e2b43c46c718:
kconfig: fix a compiliation error when using make xconfig (2013-01-30 10:16:43 +0100)
are available in the git repository at:
git://gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next
Roland Eggner (2):
kconfig: nconf: rewrite help texts
kconfig: nconf: rewrite labels of function keys line
scripts/kconfig/nconf.c | 356 +++++++++++++++++++++++------------------------
1 files changed, 174 insertions(+), 182 deletions(-)
Regards,
Yann E. MORIN
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [pull request] Pull request for branch yem-kconfig-for-next
2013-02-09 0:58 Yann E. MORIN
@ 2013-02-16 11:18 ` Yann E. MORIN
2013-02-19 12:43 ` Michal Marek
0 siblings, 1 reply; 22+ messages in thread
From: Yann E. MORIN @ 2013-02-16 11:18 UTC (permalink / raw)
To: linux-kbuild; +Cc: Michal Marek, Roland Eggner, Dmitry Voytik
Michal, All,
On Saturday 09 February 2013 Yann E. MORIN wrote:
> This series by Roland, updates the help texts for the nconf frontends, and
> brings it from its lingering state to (to my knowledge) an up-to-date and
> complete coverage of nconf.
>
> Please apply for 3.9.
>
> The following changes since commit aed9934bf182c049d966bd106ad7e2b43c46c718:
>
> kconfig: fix a compiliation error when using make xconfig (2013-01-30 10:16:43 +0100)
>
> are available in the git repository at:
> git://gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next
>
> Roland Eggner (2):
> kconfig: nconf: rewrite help texts
> kconfig: nconf: rewrite labels of function keys line
>
> scripts/kconfig/nconf.c | 356 +++++++++++++++++++++++------------------------
> 1 files changed, 174 insertions(+), 182 deletions(-)
Ping? ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [pull request] Pull request for branch yem-kconfig-for-next
2013-02-16 11:18 ` Yann E. MORIN
@ 2013-02-19 12:43 ` Michal Marek
2013-02-19 18:16 ` Yann E. MORIN
0 siblings, 1 reply; 22+ messages in thread
From: Michal Marek @ 2013-02-19 12:43 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: linux-kbuild, Roland Eggner, Dmitry Voytik
On 16.2.2013 12:18, Yann E. MORIN wrote:
> Michal, All,
>
> On Saturday 09 February 2013 Yann E. MORIN wrote:
>> This series by Roland, updates the help texts for the nconf frontends, and
>> brings it from its lingering state to (to my knowledge) an up-to-date and
>> complete coverage of nconf.
>>
>> Please apply for 3.9.
>>
>> The following changes since commit aed9934bf182c049d966bd106ad7e2b43c46c718:
>>
>> kconfig: fix a compiliation error when using make xconfig (2013-01-30 10:16:43 +0100)
>>
>> are available in the git repository at:
>> git://gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next
>>
>> Roland Eggner (2):
>> kconfig: nconf: rewrite help texts
>> kconfig: nconf: rewrite labels of function keys line
>>
>> scripts/kconfig/nconf.c | 356 +++++++++++++++++++++++------------------------
>> 1 files changed, 174 insertions(+), 182 deletions(-)
>
> Ping? ;-)
Pulled now, sorry for the delay.
Michal
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [pull request] Pull request for branch yem-kconfig-for-next
2013-02-19 12:43 ` Michal Marek
@ 2013-02-19 18:16 ` Yann E. MORIN
2013-02-20 9:57 ` Michal Marek
0 siblings, 1 reply; 22+ messages in thread
From: Yann E. MORIN @ 2013-02-19 18:16 UTC (permalink / raw)
To: linux-kbuild; +Cc: Michal Marek, Roland Eggner, Dmitry Voytik
Michal, All,
On Tuesday 19 February 2013 Michal Marek wrote:
> > On Saturday 09 February 2013 Yann E. MORIN wrote:
> >> This series by Roland, updates the help texts for the nconf frontends, and
> >> brings it from its lingering state to (to my knowledge) an up-to-date and
> >> complete coverage of nconf.
> Pulled now, sorry for the delay.
No problem, thank you!
Shall I continue gathering kconfig changes there for you to pull?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [pull request] Pull request for branch yem-kconfig-for-next
2013-02-19 18:16 ` Yann E. MORIN
@ 2013-02-20 9:57 ` Michal Marek
0 siblings, 0 replies; 22+ messages in thread
From: Michal Marek @ 2013-02-20 9:57 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: linux-kbuild, Roland Eggner, Dmitry Voytik
On 19.2.2013 19:16, Yann E. MORIN wrote:
> Michal, All,
>
> On Tuesday 19 February 2013 Michal Marek wrote:
>>> On Saturday 09 February 2013 Yann E. MORIN wrote:
>>>> This series by Roland, updates the help texts for the nconf frontends, and
>>>> brings it from its lingering state to (to my knowledge) an up-to-date and
>>>> complete coverage of nconf.
>> Pulled now, sorry for the delay.
>
> No problem, thank you!
>
> Shall I continue gathering kconfig changes there for you to pull?
It definitely helps me, so I appreciate if you continue doing this!
Michal
^ permalink raw reply [flat|nested] 22+ messages in thread
* [pull request] Pull request for branch yem-kconfig-for-next
@ 2013-04-22 21:31 Yann E. MORIN
2013-04-23 7:07 ` Yann E. MORIN
0 siblings, 1 reply; 22+ messages in thread
From: Yann E. MORIN @ 2013-04-22 21:31 UTC (permalink / raw)
To: linux-kbuild; +Cc: Michal Marek, Yann E. MORIN, Benjamin Poirier
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
Michal,
Here is the official pull-request for the kconfig-related changes I've
gathered from the list and accumulated for inclusin in 3.9:
- memory leak fixed in mconf
- randconfig fix when randomising choices
- navigation breadcrumbs in mconf
- randconfig improvements: seed, and probability skew
The following changes since commit a45c7dfb942b6c198d5cd283f8dcee145241a017:
merge_config.sh: Avoid creating unnessary source softlinks (2013-04-10 10:55:22 +0200)
are available in the git repository at:
git://gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next
for you to fetch changes up to 4fc22ca2dc3096784fbd87c1cfef7e2bce153f40:
kconfig: do randomise choice entries in presence of KCONFIG_ALLCONFIG (2013-04-16 22:00:33 +0200)
----------------------------------------------------------------
Benjamin Poirier (2):
menuconfig: Fix memory leak introduced by jump keys feature
menuconfig: Add "breadcrumbs" navigation aid
Yann E. MORIN (4):
kconfig/lxdialog: rationalise the include paths where to find {.n}curses{,w}.h
kconfig: allow specifying the seed for randconfig
kconfig: implement KCONFIG_PROBABILITY for randconfig
kconfig: do randomise choice entries in presence of KCONFIG_ALLCONFIG
Documentation/kbuild/kconfig.txt | 26 ++++++++++
scripts/kconfig/conf.c | 12 ++++-
scripts/kconfig/confdata.c | 29 ++++++++---
scripts/kconfig/list.h | 40 +++++++++++++++
scripts/kconfig/lxdialog/check-lxdialog.sh | 4 +-
scripts/kconfig/lxdialog/dialog.h | 7 +++
scripts/kconfig/lxdialog/util.c | 45 ++++++++++++++++-
scripts/kconfig/mconf.c | 74 +++++++++++++++++++++++++++-
8 files changed, 225 insertions(+), 12 deletions(-)
Regards,
Yann E. MORIN
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [pull request] Pull request for branch yem-kconfig-for-next
2013-04-22 21:31 Yann E. MORIN
@ 2013-04-23 7:07 ` Yann E. MORIN
0 siblings, 0 replies; 22+ messages in thread
From: Yann E. MORIN @ 2013-04-23 7:07 UTC (permalink / raw)
To: linux-kbuild; +Cc: Michal Marek, Benjamin Poirier
Michal, All,
On Monday 22 April 2013 23:31:19 Yann E. MORIN wrote:
> Here is the official pull-request for the kconfig-related changes I've
> gathered from the list and accumulated for inclusin in 3.9:
3.10! I meant: for 3.10! :-)
Sorry for the confusion...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ |
| --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. |
'------------------------------'-------'------------------'--------------------'
^ permalink raw reply [flat|nested] 22+ messages in thread
* [pull request] Pull request for branch yem-kconfig-for-next
@ 2013-04-26 22:17 Yann E. MORIN
2013-04-29 12:09 ` Michal Marek
0 siblings, 1 reply; 22+ messages in thread
From: Yann E. MORIN @ 2013-04-26 22:17 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, Sedat Dilek, Arnd Bergmann, Michal Marek,
Yann E. MORIN
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
Michal,
Please pull this to revert:
422c809: fix randomising choice entries in presence of KCONFIG_ALLCONFIG
It causes more harm that it fixes issues, and I couldn't find a proper
fix for now. To avoid breakage so close to the opening of the merge
window, it makes more sense to revert it than to wait for a fix.
As I already said earlier, I'll be on vacation the next two weeks, so
I should find some time to look back at this again, hopefully before
-rc1 is out (but any sane person that value his/her life should not hold
his/her breath...)
The following changes since commit e43956e607692f9b1c710311e4a6591ffba1edf0:
kconfig: implement KCONFIG_PROBABILITY for randconfig (2013-04-25 00:16:30 +0200)
are available in the git repository at:
git://gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next
for you to fetch changes up to 23a5dfdad22a574d19d7cc19b391f9ce0d3c2f21:
Revert "kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG" (2013-04-26 23:21:59 +0200)
----------------------------------------------------------------
Yann E. MORIN (1):
Revert "kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG"
scripts/kconfig/confdata.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
Regards,
Yann E. MORIN
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [pull request] Pull request for branch yem-kconfig-for-next
2013-04-26 22:17 Yann E. MORIN
@ 2013-04-29 12:09 ` Michal Marek
0 siblings, 0 replies; 22+ messages in thread
From: Michal Marek @ 2013-04-29 12:09 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: linux-kbuild, linux-kernel, Sedat Dilek, Arnd Bergmann
On 27.4.2013 00:17, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Michal,
>
> Please pull this to revert:
> 422c809: fix randomising choice entries in presence of KCONFIG_ALLCONFIG
Pulled, thanks!
Michal
^ permalink raw reply [flat|nested] 22+ messages in thread
* [pull request] Pull request for branch yem-kconfig-for-next
@ 2013-04-29 17:59 Yann E. MORIN
2013-04-29 17:59 ` [PATCH 1/1] kconfig: fix lists definition for C++ Yann E. MORIN
2013-05-02 8:48 ` [pull request] Pull request for branch yem-kconfig-for-next Michal Marek
0 siblings, 2 replies; 22+ messages in thread
From: Yann E. MORIN @ 2013-04-29 17:59 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, linux-next, Randy Dunlap, Michal Marek,
Yann E. MORIN
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
Michal,
Please pull this fix to restore compilation of the qconf frontend.
Regards,
Yann E. MORIN.
The following changes since commit 23a5dfdad22a574d19d7cc19b391f9ce0d3c2f21:
Revert "kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG" (2013-04-26 23:21:59 +0200)
are available in the git repository at:
git://gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next
for you to fetch changes up to 21ca352b71ca252e1933b1538fe89da8a04395c3:
kconfig: fix lists definition for C++ (2013-04-29 19:55:56 +0200)
----------------------------------------------------------------
Yann E. MORIN (1):
kconfig: fix lists definition for C++
scripts/kconfig/list.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 1/1] kconfig: fix lists definition for C++
2013-04-29 17:59 [pull request] Pull request for branch yem-kconfig-for-next Yann E. MORIN
@ 2013-04-29 17:59 ` Yann E. MORIN
2013-04-29 19:28 ` Randy Dunlap
2013-05-02 8:48 ` [pull request] Pull request for branch yem-kconfig-for-next Michal Marek
1 sibling, 1 reply; 22+ messages in thread
From: Yann E. MORIN @ 2013-04-29 17:59 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, linux-next, Randy Dunlap, Michal Marek,
Yann E. MORIN, Benjamin Poirier
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
The C++ compiler is more strict in that it refuses to assign
a void* to a struct list_head*.
Fix that by explicitly casting the poisonning constants.
(Tested with all 5 frontends, now.)
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Benjamin Poirier <bpoirier@suse.de>
---
scripts/kconfig/list.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/kconfig/list.h b/scripts/kconfig/list.h
index ea1d581..685d80e 100644
--- a/scripts/kconfig/list.h
+++ b/scripts/kconfig/list.h
@@ -125,7 +125,7 @@ static inline void __list_del(struct list_head *prev, struct list_head *next)
static inline void list_del(struct list_head *entry)
{
__list_del(entry->prev, entry->next);
- entry->next = LIST_POISON1;
- entry->prev = LIST_POISON2;
+ entry->next = (struct list_head*)LIST_POISON1;
+ entry->prev = (struct list_head*)LIST_POISON2;
}
#endif
--
1.8.1.2
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH 1/1] kconfig: fix lists definition for C++
2013-04-29 17:59 ` [PATCH 1/1] kconfig: fix lists definition for C++ Yann E. MORIN
@ 2013-04-29 19:28 ` Randy Dunlap
2013-04-29 21:54 ` Rob Landley
0 siblings, 1 reply; 22+ messages in thread
From: Randy Dunlap @ 2013-04-29 19:28 UTC (permalink / raw)
To: Yann E. MORIN
Cc: linux-kbuild, linux-kernel, linux-next, Michal Marek,
Benjamin Poirier
On 04/29/13 10:59, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> The C++ compiler is more strict in that it refuses to assign
> a void* to a struct list_head*.
>
> Fix that by explicitly casting the poisonning constants.
>
> (Tested with all 5 frontends, now.)
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Benjamin Poirier <bpoirier@suse.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> scripts/kconfig/list.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kconfig/list.h b/scripts/kconfig/list.h
> index ea1d581..685d80e 100644
> --- a/scripts/kconfig/list.h
> +++ b/scripts/kconfig/list.h
> @@ -125,7 +125,7 @@ static inline void __list_del(struct list_head *prev, struct list_head *next)
> static inline void list_del(struct list_head *entry)
> {
> __list_del(entry->prev, entry->next);
> - entry->next = LIST_POISON1;
> - entry->prev = LIST_POISON2;
> + entry->next = (struct list_head*)LIST_POISON1;
> + entry->prev = (struct list_head*)LIST_POISON2;
> }
> #endif
>
--
~Randy
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/1] kconfig: fix lists definition for C++
2013-04-29 19:28 ` Randy Dunlap
@ 2013-04-29 21:54 ` Rob Landley
2013-04-29 22:30 ` Yann E. MORIN
0 siblings, 1 reply; 22+ messages in thread
From: Rob Landley @ 2013-04-29 21:54 UTC (permalink / raw)
To: Randy Dunlap
Cc: Yann E. MORIN, linux-kbuild, linux-kernel, linux-next,
Michal Marek, Benjamin Poirier
On 04/29/2013 02:28:07 PM, Randy Dunlap wrote:
> On 04/29/13 10:59, Yann E. MORIN wrote:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > The C++ compiler is more strict in that it refuses to assign
> > a void* to a struct list_head*.
Given that the code _isn't_ C++ (because C is not a subset of C++ but a
separate langauge in its own right where "throw" is a legitimate
variable name and so on), how is this an issue?
Rob
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/1] kconfig: fix lists definition for C++
2013-04-29 21:54 ` Rob Landley
@ 2013-04-29 22:30 ` Yann E. MORIN
2013-04-29 22:57 ` Rob Landley
0 siblings, 1 reply; 22+ messages in thread
From: Yann E. MORIN @ 2013-04-29 22:30 UTC (permalink / raw)
To: Rob Landley
Cc: Randy Dunlap, linux-kbuild, linux-kernel, linux-next,
Michal Marek, Benjamin Poirier
Rob, All,
On Mon, Apr 29, 2013 at 04:54:14PM -0500, Rob Landley wrote:
> On 04/29/2013 02:28:07 PM, Randy Dunlap wrote:
> >On 04/29/13 10:59, Yann E. MORIN wrote:
> >> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >>
> >> The C++ compiler is more strict in that it refuses to assign
> >> a void* to a struct list_head*.
>
> Given that the code _isn't_ C++ (because C is not a subset of C++ but a
> separate langauge in its own right where "throw" is a legitimate variable
> name and so on), how is this an issue?
It's an issue because the xconfig frontends is qconf, which as the name
implies is using Qt, which *is* C++, and includes list.h.
So, list.h is included by both by C and C++ code.
So yes, list.h can be compiled by a C++ compiler.
Now, granted: list.h should all be enclosed in:
ifdef __cpluplus
extern "C" {
endif
...
ifdef __cpluplus
}
endif
Was that the fix you were suggesting between the lines? ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/1] kconfig: fix lists definition for C++
2013-04-29 22:30 ` Yann E. MORIN
@ 2013-04-29 22:57 ` Rob Landley
0 siblings, 0 replies; 22+ messages in thread
From: Rob Landley @ 2013-04-29 22:57 UTC (permalink / raw)
To: Yann E. MORIN
Cc: Randy Dunlap, linux-kbuild, linux-kernel, linux-next,
Michal Marek, Benjamin Poirier
On 04/29/2013 05:30:54 PM, Yann E. MORIN wrote:
> Rob, All,
>
> On Mon, Apr 29, 2013 at 04:54:14PM -0500, Rob Landley wrote:
> > On 04/29/2013 02:28:07 PM, Randy Dunlap wrote:
> > >On 04/29/13 10:59, Yann E. MORIN wrote:
> > >> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > >>
> > >> The C++ compiler is more strict in that it refuses to assign
> > >> a void* to a struct list_head*.
> >
> > Given that the code _isn't_ C++ (because C is not a subset of C++
> but a
> > separate langauge in its own right where "throw" is a legitimate
> variable
> > name and so on), how is this an issue?
>
> It's an issue because the xconfig frontends is qconf, which as the
> name
> implies is using Qt, which *is* C++, and includes list.h.
>
> So, list.h is included by both by C and C++ code.
>
> So yes, list.h can be compiled by a C++ compiler.
>
> Now, granted: list.h should all be enclosed in:
> ifdef __cpluplus
> extern "C" {
> endif
> ...
> ifdef __cpluplus
> }
> endif
>
> Was that the fix you were suggesting between the lines? ;-)
It does more clearly document the issue. (A comment about the QT
front-end would also be nice. I don't use that one, so I didn't think
of it.)
Thanks,
Rob
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [pull request] Pull request for branch yem-kconfig-for-next
2013-04-29 17:59 [pull request] Pull request for branch yem-kconfig-for-next Yann E. MORIN
2013-04-29 17:59 ` [PATCH 1/1] kconfig: fix lists definition for C++ Yann E. MORIN
@ 2013-05-02 8:48 ` Michal Marek
1 sibling, 0 replies; 22+ messages in thread
From: Michal Marek @ 2013-05-02 8:48 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: linux-kbuild, linux-kernel, linux-next, Randy Dunlap
On 29.4.2013 19:59, Yann E. MORIN wrote:
> The following changes since commit 23a5dfdad22a574d19d7cc19b391f9ce0d3c2f21:
>
> Revert "kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG" (2013-04-26 23:21:59 +0200)
>
> are available in the git repository at:
>
> git://gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next
Pulled, thanks.
Michal
^ permalink raw reply [flat|nested] 22+ messages in thread
* [pull request] Pull request for branch yem-kconfig-for-next
@ 2013-06-18 22:44 Yann E. MORIN
2013-06-19 20:40 ` Michal Marek
0 siblings, 1 reply; 22+ messages in thread
From: Yann E. MORIN @ 2013-06-18 22:44 UTC (permalink / raw)
To: linux-kbuild; +Cc: linux-kernel, Michal Marek, Yann E. MORIN
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
Hello Michal, All!
These are the patches against kconfig that I have accumulated for 3.11,
and for which I plan to later send a proper pull-request.
Note-whorthy this time:
- fix values of tristates that are selected by boolean choices (Arve)
- fix choice randomisation in presence of KCONFIG_ALLCONFIG (me)
- fix choice randomisation selecting more than one value in
a choice (but only if it is conditional) (me)
- fix choice-in-a-choice randomisation not selecting any value
for the inner-most choice (me)
Also, some code-cleanups and eye-candy:
- mconf and nconf code cleanups (Dirk, Sedat)
- mconf and nconf eye-candy (Dirk)
- scripts/config script-name in help text (Clément)
- heuristic to sort found symbols by relevance (me)
- more randconfig debugging help (me)
Note: this series is for review before I send an official pull-request.
I want to avoid the debacle [0] [1] of the last kconfig breakage I caused
with my previous kconfig "fix" to randomising choices in presence of
KCONFIG_ALLCONFIG.
I would like to send an official pull-request early next week, so all of
these can land early in -next, so they get some real-life t4esting before
the next merge windows open. So please, please, test this carefully. ;-)
[0] http://marc.info/?t=136684274600002&r=1&w=2
[1] http://marc.info/?t=136696367200003&r=1&w=2
Regards,
Yann E. MORIN.
The following changes since commit f722406faae2d073cc1d01063d1123c35425939e:
Linux 3.10-rc1 (2013-05-11 17:14:08 -0700)
are available in the git repository at:
git://gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next
for you to fetch changes up to b4e0ac8385fecde0363a2499323f81b4a91e8430:
kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG (2013-06-18 23:59:02 +0200)
----------------------------------------------------------------
Arve Hjønnevåg (1):
kconfig: Fix defconfig when one choice menu selects options that another choice menu depends on
Clement Chauplannaz (1):
scripts/config: replace hard-coded script name by a dynamic value
Dirk Gouders (4):
kconfig/lxdialog: handle newline characters in print_autowrap()
mconf: use function calls instead of ncurses' variables LINES and COLS
nconf: use function calls instead of ncurses' variables LINES and COLS
mconf/nconf: mark empty menus/menuconfigs different from non-empty ones
Sedat Dilek (2):
kconfig/lxdialog: Add definitions for mininimum (re)size values
kconfig/lxdialog: Use new mininimum resize definitions in conf_choice()
Yann E. MORIN (6):
kconfig/conf: fix randconfig setting multiple symbols in a choice
kconfig/conf: accept a base-16 seed for randconfig
kconfig/conf: print the seed used to initialise the RNG for randconfig
kconfig: sort found symbols by relevance
kconfig: loop as long as we changed some symbols in randconfig
kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG
scripts/config | 12 ++--
scripts/kconfig/conf.c | 6 +-
scripts/kconfig/confdata.c | 39 +++++++++----
scripts/kconfig/expr.h | 3 +
scripts/kconfig/lkc.h | 3 +-
scripts/kconfig/lkc_proto.h | 1 +
scripts/kconfig/lxdialog/checklist.c | 8 +--
scripts/kconfig/lxdialog/dialog.h | 14 +++++
scripts/kconfig/lxdialog/inputbox.c | 8 +--
scripts/kconfig/lxdialog/menubox.c | 6 +-
scripts/kconfig/lxdialog/textbox.c | 6 +-
scripts/kconfig/lxdialog/util.c | 46 ++++++++-------
scripts/kconfig/lxdialog/yesno.c | 8 +--
scripts/kconfig/mconf.c | 19 ++++---
scripts/kconfig/menu.c | 16 ++++++
scripts/kconfig/nconf.c | 37 +++++++-----
scripts/kconfig/nconf.gui.c | 20 ++++---
scripts/kconfig/symbol.c | 107 ++++++++++++++++++++++++++++++++---
18 files changed, 263 insertions(+), 96 deletions(-)
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [pull request] Pull request for branch yem-kconfig-for-next
2013-06-18 22:44 Yann E. MORIN
@ 2013-06-19 20:40 ` Michal Marek
2013-06-19 21:01 ` Yann E. MORIN
0 siblings, 1 reply; 22+ messages in thread
From: Michal Marek @ 2013-06-19 20:40 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: linux-kbuild, linux-kernel
Dne 19.6.2013 00:44, Yann E. MORIN napsal(a):
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Hello Michal, All!
>
> These are the patches against kconfig that I have accumulated for 3.11,
> and for which I plan to later send a proper pull-request.
>
> Note-whorthy this time:
> - fix values of tristates that are selected by boolean choices (Arve)
> - fix choice randomisation in presence of KCONFIG_ALLCONFIG (me)
> - fix choice randomisation selecting more than one value in
> a choice (but only if it is conditional) (me)
> - fix choice-in-a-choice randomisation not selecting any value
> for the inner-most choice (me)
>
> Also, some code-cleanups and eye-candy:
> - mconf and nconf code cleanups (Dirk, Sedat)
> - mconf and nconf eye-candy (Dirk)
> - scripts/config script-name in help text (Clément)
> - heuristic to sort found symbols by relevance (me)
> - more randconfig debugging help (me)
>
> Note: this series is for review before I send an official pull-request.
> I want to avoid the debacle [0] [1] of the last kconfig breakage I caused
> with my previous kconfig "fix" to randomising choices in presence of
> KCONFIG_ALLCONFIG.
>
> I would like to send an official pull-request early next week, so all of
> these can land early in -next, so they get some real-life t4esting before
> the next merge windows open. So please, please, test this carefully. ;-)
I tested this a bit, it works fine. Unless somebody else finds issues,
I'll merge it.
Thanks,
Michal
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [pull request] Pull request for branch yem-kconfig-for-next
2013-06-19 20:40 ` Michal Marek
@ 2013-06-19 21:01 ` Yann E. MORIN
0 siblings, 0 replies; 22+ messages in thread
From: Yann E. MORIN @ 2013-06-19 21:01 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-kbuild, linux-kernel
Michal, All,
On 2013-06-19 22:40 +0200, Michal Marek spake thusly:
> Dne 19.6.2013 00:44, Yann E. MORIN napsal(a):
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > Hello Michal, All!
> >
> > These are the patches against kconfig that I have accumulated for 3.11,
> > and for which I plan to later send a proper pull-request.
> >
> > Note-whorthy this time:
> > - fix values of tristates that are selected by boolean choices (Arve)
> > - fix choice randomisation in presence of KCONFIG_ALLCONFIG (me)
> > - fix choice randomisation selecting more than one value in
> > a choice (but only if it is conditional) (me)
> > - fix choice-in-a-choice randomisation not selecting any value
> > for the inner-most choice (me)
> >
> > Also, some code-cleanups and eye-candy:
> > - mconf and nconf code cleanups (Dirk, Sedat)
> > - mconf and nconf eye-candy (Dirk)
> > - scripts/config script-name in help text (Clément)
> > - heuristic to sort found symbols by relevance (me)
> > - more randconfig debugging help (me)
> >
> > Note: this series is for review before I send an official pull-request.
> > I want to avoid the debacle [0] [1] of the last kconfig breakage I caused
> > with my previous kconfig "fix" to randomising choices in presence of
> > KCONFIG_ALLCONFIG.
> >
> > I would like to send an official pull-request early next week, so all of
> > these can land early in -next, so they get some real-life t4esting before
> > the next merge windows open. So please, please, test this carefully. ;-)
>
> I tested this a bit, it works fine. Unless somebody else finds issues,
> I'll merge it.
Could you please wait a few days (say friday, or monday), I know someone
whose supposed to do some testing on his use-case (Hello Thomas! ;-) ).
Thank you!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 22+ messages in thread
* [pull request] Pull request for branch yem-kconfig-for-next
@ 2013-06-29 14:21 Yann E. MORIN
0 siblings, 0 replies; 22+ messages in thread
From: Yann E. MORIN @ 2013-06-29 14:21 UTC (permalink / raw)
To: linux-kbuild; +Cc: linux-kernel, Michal Marek, Yann E. MORIN, Kees Cook
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
Hello Michal, All,
Please pull this kconfig fix from Kees that enables 64-bit-wide
(ie. signed long) [int,hex] ranges.
Regards,
Yann E. MORIN.
The following changes since commit 490f16171119a16e05d670306c105f3b45c38837:
Revert "kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG" (2013-06-26 15:49:00 +0200)
are available in the git repository at:
git://gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next
for you to fetch changes up to b57caaaed2bd127fe656e6c145970ed6a05c0125:
kconfig: allow "hex" and "range" to support longs (2013-06-29 15:30:17 +0200)
----------------------------------------------------------------
Kees Cook (1):
kconfig: allow "hex" and "range" to support longs
scripts/kconfig/symbol.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2013-06-29 14:21 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-29 17:59 [pull request] Pull request for branch yem-kconfig-for-next Yann E. MORIN
2013-04-29 17:59 ` [PATCH 1/1] kconfig: fix lists definition for C++ Yann E. MORIN
2013-04-29 19:28 ` Randy Dunlap
2013-04-29 21:54 ` Rob Landley
2013-04-29 22:30 ` Yann E. MORIN
2013-04-29 22:57 ` Rob Landley
2013-05-02 8:48 ` [pull request] Pull request for branch yem-kconfig-for-next Michal Marek
-- strict thread matches above, loose matches on Subject: below --
2013-06-29 14:21 Yann E. MORIN
2013-06-18 22:44 Yann E. MORIN
2013-06-19 20:40 ` Michal Marek
2013-06-19 21:01 ` Yann E. MORIN
2013-04-26 22:17 Yann E. MORIN
2013-04-29 12:09 ` Michal Marek
2013-04-22 21:31 Yann E. MORIN
2013-04-23 7:07 ` Yann E. MORIN
2013-02-09 0:58 Yann E. MORIN
2013-02-16 11:18 ` Yann E. MORIN
2013-02-19 12:43 ` Michal Marek
2013-02-19 18:16 ` Yann E. MORIN
2013-02-20 9:57 ` Michal Marek
2013-01-15 23:12 Yann E. MORIN
2013-01-24 10:44 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox