From: Randy Dunlap <rdunlap@infradead.org>
To: Phil Carmody <pc+lkml@asdf.org>
Cc: mmarek@suse.cz, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Makefile: make sparse (CHECK) user-selectable
Date: Wed, 08 May 2013 10:44:06 -0700 [thread overview]
Message-ID: <518A8EE6.90206@infradead.org> (raw)
In-Reply-To: <1368026580-26897-1-git-send-email-pc+lkml@asdf.org>
On 05/08/13 08:23, Phil Carmody wrote:
> I've got a tweaked version as well as the system default,
> so make the sparse binary that's run user-selectable.
>
I'm confused about why this patch is necessary since I already do
$ make O=builddir CHECK=/path/to/sparse all
> Signed-off-by: Phil Carmody <pc+lkml@asdf.org>
> ---
> Makefile | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index a3a834b..e7a4851 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -338,7 +338,9 @@ GENKSYMS = scripts/genksyms/genksyms
> INSTALLKERNEL := installkernel
> DEPMOD = /sbin/depmod
> PERL = perl
> -CHECK = sparse
> +ifndef CHECK
> + CHECK = sparse
> +endif
>
> CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ \
> -Wbitwise -Wno-return-void $(CF)
>
--
~Randy
next prev parent reply other threads:[~2013-05-08 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 15:23 [PATCH] Makefile: make sparse (CHECK) user-selectable Phil Carmody
2013-05-08 17:44 ` Randy Dunlap [this message]
2013-05-10 2:37 ` Phil Carmody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518A8EE6.90206@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=pc+lkml@asdf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox