Blocking allmodconfig with missing defaults (was: Re: kbuild: Fix missing '\n' for NEW symbols in yes "" | make oldconfig >conf.new)

Blocking allmodconfig with missing defaults (was: Re: kbuild: Fix missing '\n' for NEW symbols in yes "" | make oldconfig >conf.new)

[Geert Uytterhoeven]

On Wed, Feb 27, 2013 at 9:37 PM, Linux Kernel Mailing List
<linux-kernel@vger.kernel.org> wrote:
> Gitweb:     http://git.kernel.org/linus/;a=commit;h=62dc989921df2a98d1a73aacd085abe941cb9828
>
>     According to Documentation/kbuild/kconfig.txt, the commands:
>
>         yes "" | make oldconfig >conf.new
>         grep "(NEW)" conf.new
>
>     should list the new config symbols with their default values.

There are other cases where this is not working.
If there are int or hex symbols without a default value, "allmodconfig",
"allyesconfig", "allnoconfig", and "randconfig" fill in empty string values,
causing a subsequent build (which does oldconfig) to wait for user input.

This is easy to reproduce:
    make ARCH=h8300 allmodconfig
    make ARCH=h8300 oldconfig

Should kconfig generate default values for these cases?
Should all int/hex symbols provide default values? If yes, I think
kconfig should
complain about missing defaults.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: Blocking allmodconfig with missing defaults (was: Re: kbuild: Fix missing '\n' for NEW symbols in yes "" | make oldconfig >conf.new)

[Michal Marek]

On 23.5.2013 11:52, Geert Uytterhoeven wrote:
> On Wed, Feb 27, 2013 at 9:37 PM, Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org> wrote:
>> Gitweb:     http://git.kernel.org/linus/;a=commit;h=62dc989921df2a98d1a73aacd085abe941cb9828
>>
>>     According to Documentation/kbuild/kconfig.txt, the commands:
>>
>>         yes "" | make oldconfig >conf.new
>>         grep "(NEW)" conf.new
>>
>>     should list the new config symbols with their default values.
> 
> There are other cases where this is not working.
> If there are int or hex symbols without a default value, "allmodconfig",
> "allyesconfig", "allnoconfig", and "randconfig" fill in empty string values,
> causing a subsequent build (which does oldconfig) to wait for user input.
> 
> This is easy to reproduce:
>     make ARCH=h8300 allmodconfig
>     make ARCH=h8300 oldconfig
> 
> Should kconfig generate default values for these cases?

Yes, I think that we should generate a default of 0 / 0x0 or the lower
bound of the range, if specified.

Michal