From: Michal Marek <mmarek@suse.cz>
To: "Marciniszyn, Mike" <mike.marciniszyn@intel.com>
Cc: "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
Doug Ledford <dledford@redhat.com>
Subject: Re: [RFC PATCH v3] kbuild: fix error when building from src rpm
Date: Wed, 05 Jun 2013 11:53:42 +0200 [thread overview]
Message-ID: <51AF0AA6.8010008@suse.cz> (raw)
In-Reply-To: <32E1700B9017364D9B60AED9960492BC2114956E@FMSMSX107.amr.corp.intel.com>
On 4.6.2013 22:12, Marciniszyn, Mike wrote:
> Sorry for the confusion with the patch.
>
> The latest version I've changed to an RFC because of some testing
> issues I've encountered.
>
> The /sbin/installkernel doesn't behave very nicely when INSTALL_PATH
> is modified on RH6.4.
[snip]
> I'm seeing when spec file tries to do its own install...
>
> I'm open to suggestions for making this part of the spec file
> portable and the src RPM usable.
You could introduce a new Makefile target, say image_name, that would
simply print the image name after including the arch Makefile. Then in
the spec file, you would simply do
KBUILD_IMAGE=$(make -s image_name)
I think that this target would be a useful addition to the already
existing kernelversion and kernelrelease targets. And BTW, we could use
make -s kernelrelease in the specfile as well, instead of hardcoding the
value there.
Michal
next prev parent reply other threads:[~2013-06-05 9:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 20:12 [RFC PATCH v3] kbuild: fix error when building from src rpm Marciniszyn, Mike
2013-06-05 9:53 ` Michal Marek [this message]
2013-06-05 10:17 ` Marciniszyn, Mike
2013-06-05 14:06 ` Doug Ledford
-- strict thread matches above, loose matches on Subject: below --
2013-06-04 19:37 Mike Marciniszyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF0AA6.8010008@suse.cz \
--to=mmarek@suse.cz \
--cc=dledford@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox