Re: Kconfig Gtk/Qt interface flavours ported to newest toolkit versions

Yann E. MORIN
2013-07-03T16:30:43Z

David, All,

On 2013-07-02 17:22 +0200, davidgraeff spake thusly:
> I've no idea if this is the right way to send patches. I'm kind of new to this.

It seems you're doing mostly fine! :-)

However, since you asked: your patches are numberedd 2 to 9. It seems
you considered the intro mail (the one I'm replying to here) as the
number one. Is that right, or is patch #1 missing?

Usually, patch series are sent as thus:
[PATCH 0/N] Subject for intro mail, aka "cover letter"
[PATCH 1/N] Subject for first actual patch
[PATCH 2/N] Subject for second actual patch
[...]
[PATCH N-1/N] Subject for penultimate actual patch
[PATCH N/N] Subject for last actual patch

You can achieve this using 'git send-email'. See:
git help send-email

Also, see (albeit not totaly up-to-date):
Documentation/SubmittingPatches

Nit-picking: please keep your mails and commit messages below 80-chars
per line, it's easier to read. Thanks! :-)

> Attached is a patchset basically for porting the graphical Gtk and Qt flavours
> to their latest toolkit versions (Gtk3 and Qt4 with compatibility to Qt5 respectively).

I did not do any review of the patches, since I have a concern about the
series. It happens very often that, in enterprise ecosystems, the host
build machines are running rather aging distro, such as RHEL 5 (or even
RHEL 4 in some cases), so I think we still want the new kernels to be
buildable (and thus configurable) on such machines (eg. for
cross-compilation).

I have no idea when such enterprise distros have started bundling GTK3
or Qt4/5, but given RHEL-4 (which is still use in some places) is 8
years old, I doubt the new frontends would build on those distros.

> I do not know if it was on purpose to keep all flavours except lxdialog in one single directory,

Historical artifact, I think... :-(

[--SNIP--]
> Those newer graphical kconfig flavours will be used by a project I'm involved in so
> I will maintain it for the next couple of months.

Could you please explain what this project of yours is about?

> If I did anything wrong, please instruct me or provide me a link please.

As I said above, mostly good. I've seen far worse submnissions, don't
worry! ;-)

Regards,
Yann E. MORIN.

PS. Sorry for not answering earlier, I had connection issues yesterday,
during all the evening & night. :-(
YEM.

--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'