Re: [PATCH v2 0/4] Gtk/Qt interface flavours ported to newest toolkit versions

Michal Marek
2013-08-16T14:02:18Z

On 16.8.2013 15:36, Yann E. MORIN wrote:
> Michal, David, All,
>
> On Friday 16 August 2013 15:28:16 Michal Marek wrote:
>> On 4.8.2013 12:38, David Graeff wrote:
>>> KConf: Move flavours into their own subdirectories.
>>> KConf: Update/Port Gtk flavour to use Gtk3
>>> KConf: Qt interface port to Qt4/Qt5, removed Qt3 Support
>>> KConf: images.c for gtk/qt gui flavour reoganized
>>
>> I only received 1/4 and 4/4 through the mailing list. Perhaps vger
>> rejected the other two patches for size reasons? I know that Yann told
>> to to send full copies of patches instead of pull request, but could you
>> please create a repository on some git hosting site and publish the
>> patches there _in addition to_ sending them by mail?
>
> Indeed, they are big patches.
>
> I postponed getting them in my branch in waiting to get more reviews on
> these, since I'm not really comfortable with Qt/GTK.
>
> I'll eventually get them, and if there are enough good reviews coming in
> before 3.12, I'll queue them for 3.12; otherwise, I was aiming for 3.13.

I think the first patch can be applied easily, provided David sends a
new version that addresses Sam's review. Regarding the actual port to
newer Gtk / Qt, I'd like to see the patches, too :).

Michal