* [PATCH] Provide version number for Debian firmware package
@ 2013-08-11 19:55 Heinrich Schuchardt
2013-08-13 20:20 ` Michal Marek
0 siblings, 1 reply; 5+ messages in thread
From: Heinrich Schuchardt @ 2013-08-11 19:55 UTC (permalink / raw)
To: mmarek; +Cc: linux-kbuild, xypron.glpk
scripts/package/builddeb is used to create Debian packages.
Currently the firmware package always gets the same version number
irrespective of the Kernel version.
The paths inside the firmware package depend on the Kernel
version.
With the patch supplied the Kernel version becomes part of the
Debian firmware package number.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
scripts/package/builddeb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index acb8650..4ca6111 100644
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -79,7 +79,7 @@ fwdir="$objtree/debian/fwtmp"
kernel_headers_dir="$objtree/debian/hdrtmp"
libc_headers_dir="$objtree/debian/headertmp"
packagename=linux-image-$version
-fwpackagename=linux-firmware-image
+fwpackagename=linux-firmware-image-$version
kernel_headers_packagename=linux-headers-$version
libc_headers_packagename=linux-libc-dev
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Provide version number for Debian firmware package
2013-08-11 19:55 [PATCH] Provide version number for Debian firmware package Heinrich Schuchardt
@ 2013-08-13 20:20 ` Michal Marek
2013-08-13 21:02 ` Ben Hutchings
0 siblings, 1 reply; 5+ messages in thread
From: Michal Marek @ 2013-08-13 20:20 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: linux-kbuild, maximilian attems, Ben Hutchings
Dne 11.8.2013 21:55, Heinrich Schuchardt napsal(a):
> scripts/package/builddeb is used to create Debian packages.
> Currently the firmware package always gets the same version number
> irrespective of the Kernel version.
> The paths inside the firmware package depend on the Kernel
> version.
>
> With the patch supplied the Kernel version becomes part of the
> Debian firmware package number.
Ben, Max, is this how the official linux-firmware-image package is built
in Debian? The change makes sense to me.
Michal
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> scripts/package/builddeb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index acb8650..4ca6111 100644
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -79,7 +79,7 @@ fwdir="$objtree/debian/fwtmp"
> kernel_headers_dir="$objtree/debian/hdrtmp"
> libc_headers_dir="$objtree/debian/headertmp"
> packagename=linux-image-$version
> -fwpackagename=linux-firmware-image
> +fwpackagename=linux-firmware-image-$version
> kernel_headers_packagename=linux-headers-$version
> libc_headers_packagename=linux-libc-dev
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Provide version number for Debian firmware package
2013-08-13 20:20 ` Michal Marek
@ 2013-08-13 21:02 ` Ben Hutchings
2013-08-14 18:15 ` maximilian attems
0 siblings, 1 reply; 5+ messages in thread
From: Ben Hutchings @ 2013-08-13 21:02 UTC (permalink / raw)
To: Michal Marek; +Cc: Heinrich Schuchardt, linux-kbuild, maximilian attems
[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]
On Tue, 2013-08-13 at 22:20 +0200, Michal Marek wrote:
> Dne 11.8.2013 21:55, Heinrich Schuchardt napsal(a):
> > scripts/package/builddeb is used to create Debian packages.
> > Currently the firmware package always gets the same version number
> > irrespective of the Kernel version.
> > The paths inside the firmware package depend on the Kernel
> > version.
> >
> > With the patch supplied the Kernel version becomes part of the
> > Debian firmware package number.
>
> Ben, Max, is this how the official linux-firmware-image package is built
> in Debian? The change makes sense to me.
We package firmware in an entirely different (and selective) way. We
take selected files from linux-firmware.git, we don't install anything
in /lib/firmware/$version, and we use multiple package names beginning
with the prefix 'firmware-'.
I don't think it's very useful to package the firmware subdirectory -
but since builddeb is already doing so, and the generated package
installs files in /lib/firmware/$version, it would make sense to include
$version in the package name.
Ben.
--
Ben Hutchings
Experience is what causes a person to make new mistakes instead of old ones.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Provide version number for Debian firmware package
2013-08-13 21:02 ` Ben Hutchings
@ 2013-08-14 18:15 ` maximilian attems
2013-08-15 16:02 ` Michal Marek
0 siblings, 1 reply; 5+ messages in thread
From: maximilian attems @ 2013-08-14 18:15 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Michal Marek, Heinrich Schuchardt, linux-kbuild
On Tue, 13 Aug 2013, Ben Hutchings wrote:
> On Tue, 2013-08-13 at 22:20 +0200, Michal Marek wrote:
> > Dne 11.8.2013 21:55, Heinrich Schuchardt napsal(a):
> > > scripts/package/builddeb is used to create Debian packages.
> > > Currently the firmware package always gets the same version number
> > > irrespective of the Kernel version.
> > > The paths inside the firmware package depend on the Kernel
> > > version.
> > >
> > > With the patch supplied the Kernel version becomes part of the
> > > Debian firmware package number.
> >
> > Ben, Max, is this how the official linux-firmware-image package is built
> > in Debian? The change makes sense to me.
>
> but since builddeb is already doing so, and the generated package
> installs files in /lib/firmware/$version, it would make sense to include
> $version in the package name.
acked by me too.
--
maks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Provide version number for Debian firmware package
2013-08-14 18:15 ` maximilian attems
@ 2013-08-15 16:02 ` Michal Marek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Marek @ 2013-08-15 16:02 UTC (permalink / raw)
To: maximilian attems; +Cc: Ben Hutchings, Heinrich Schuchardt, linux-kbuild
On 14.8.2013 20:15, maximilian attems wrote:
> On Tue, 13 Aug 2013, Ben Hutchings wrote:
>
>> On Tue, 2013-08-13 at 22:20 +0200, Michal Marek wrote:
>>> Dne 11.8.2013 21:55, Heinrich Schuchardt napsal(a):
>>>> scripts/package/builddeb is used to create Debian packages.
>>>> Currently the firmware package always gets the same version number
>>>> irrespective of the Kernel version.
>>>> The paths inside the firmware package depend on the Kernel
>>>> version.
>>>>
>>>> With the patch supplied the Kernel version becomes part of the
>>>> Debian firmware package number.
>>>
>>> Ben, Max, is this how the official linux-firmware-image package is built
>>> in Debian? The change makes sense to me.
>>
>> but since builddeb is already doing so, and the generated package
>> installs files in /lib/firmware/$version, it would make sense to include
>> $version in the package name.
>
> acked by me too.
Added to kbuild.git#misc now.
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-08-15 16:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-11 19:55 [PATCH] Provide version number for Debian firmware package Heinrich Schuchardt
2013-08-13 20:20 ` Michal Marek
2013-08-13 21:02 ` Ben Hutchings
2013-08-14 18:15 ` maximilian attems
2013-08-15 16:02 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox