Re: [PATCH] kconfig: Gracefully exit if the default config files are not present

[Michal Marek <mmarek@suse.cz>]

Hi Mike,

On 13.8.2013 23:29, Mike Pagano wrote:
> Gracefully exit if the default config files are not present. (.config and 
> .config.old)

Two minor nitpicks about the changelog: The subject line would be more
to the point if it mentioned the name of the utility you are fixing.
Otherwise, people might get the impression that you are fixing a tool
from scripts/kconnfig, like 'make oldconfig' or 'make menuconfig'. Just
change it to

diffconfig: Gracefully exit if the default config files are not present


> Diffconfig is a utility script for comparing kernel configuration files.

This is superfluous information. Just describe the change you made and
that's it.


> -    a = readconfig(file(configa_filename))
> -    b = readconfig(file(configb_filename))
> +    try:
> +        a = readconfig(file(configa_filename))
> +        b = readconfig(file(configb_filename))
> +    except IOError,(errno, strerror):
> +       print "I/O error(%s: %s)\n" % (errno, strerror)
> +       usage()

The second block is missing one column of indentation.

Michal