public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Mike Pagano <mpagano@gentoo.org>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kbuild: Update to diffconfig to support python 2.6 and greater
Date: Thu, 15 Aug 2013 18:00:06 +0200	[thread overview]
Message-ID: <520CFB06.1080803@suse.cz> (raw)
In-Reply-To: <520CF8A6.8030305@suse.cz>

On 15.8.2013 17:49, Michal Marek wrote:
> On 13.8.2013 23:32, Mike Pagano wrote:
>> Modification of the diffconfig script to support python versions 2.6 and 
>> greater. 
>>
>> Note that Linux distributions are starting to deprecate python versions < 2.5
> 
> Dumb question - The original script works for me with python 2.7.3 from
> openSUSE. Does python have some strict mode that would show the problems
> you are fixing? It's always good to mention the actual error to the
> changelog.

I now tried the patched version on a system with python 2.4.2 and it
fails with:
  File "../diffconfig2", line 103
    except IOError as e:
                    ^
SyntaxError: invalid syntax

The original version works fine with both 2.4.2 and 2.7.3. So should the
changelog actually read "drop support for python < 2.5"? What do we gain
by this change?

Thanks,
Michal

      reply	other threads:[~2013-08-15 16:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-13 21:32 [PATCH] kbuild: Update to diffconfig to support python 2.6 and greater Mike Pagano
2013-08-15 15:49 ` Michal Marek
2013-08-15 16:00   ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520CFB06.1080803@suse.cz \
    --to=mmarek@suse.cz \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=mpagano@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox