From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:42912 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753603Ab3HOQAO (ORCPT ); Thu, 15 Aug 2013 12:00:14 -0400 Message-ID: <520CFB06.1080803@suse.cz> Date: Thu, 15 Aug 2013 18:00:06 +0200 From: Michal Marek MIME-Version: 1.0 Subject: Re: [PATCH] kbuild: Update to diffconfig to support python 2.6 and greater References: <3029888.QLGxfpIyIk@comanche> <520CF8A6.8030305@suse.cz> In-Reply-To: <520CF8A6.8030305@suse.cz> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Mike Pagano Cc: linux-kbuild@vger.kernel.org On 15.8.2013 17:49, Michal Marek wrote: > On 13.8.2013 23:32, Mike Pagano wrote: >> Modification of the diffconfig script to support python versions 2.6 and >> greater. >> >> Note that Linux distributions are starting to deprecate python versions < 2.5 > > Dumb question - The original script works for me with python 2.7.3 from > openSUSE. Does python have some strict mode that would show the problems > you are fixing? It's always good to mention the actual error to the > changelog. I now tried the patched version on a system with python 2.4.2 and it fails with: File "../diffconfig2", line 103 except IOError as e: ^ SyntaxError: invalid syntax The original version works fine with both 2.4.2 and 2.7.3. So should the changelog actually read "drop support for python < 2.5"? What do we gain by this change? Thanks, Michal