From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:49799 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753428Ab3IMLAL (ORCPT ); Fri, 13 Sep 2013 07:00:11 -0400 Message-ID: <5232F037.4090504@suse.cz> Date: Fri, 13 Sep 2013 13:00:07 +0200 From: Michal Marek MIME-Version: 1.0 Subject: Re: [PATCH 2/4] scripts/config: use sed's POSIX interface References: <83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce.1376600922.git.yann.morin.1998@free.fr> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: =?UTF-8?B?Q2zDqW1lbnQgQ2hhdXBsYW5uYXo=?= Cc: Linus Walleij , "Yann E. MORIN" , linux-kbuild , "linux-kernel@vger.kernel.org" Dne 13.9.2013 11:54, Clément Chauplannaz napsal(a): > On Sep 13, 2013, at 11:32 AM, Linus Walleij wrote: > >> On Fri, Sep 13, 2013 at 10:38 AM, Clément Chauplannaz >> wrote: >> >>> Thank you for this report. I was able to reproduce this bug and fix it. >> >> Thanks! Tested and works fine. > Glad to read the patch solves your issue. Thanks for the quick feedback! >> >>> My previous commit changed the separator between sed's substitute >>> command and its parameters, from ':' to '/'. The latter conflicted >>> with the slashes found in the value of variable CMDLINE, as provided >>> in your email. >> >> Hm it could actually be useful to be able to have colons in a CMDLINE, >> I wonder if we can think about some better separator ... oh well that >> is another issue, all old scripts work now anyway. > Indeed config script may not work with all possible string values. > My > first concern for now was to fallback to previous interface. We may look > into hardening the script later on. Right. I will merge the patch because it reverts a regression. But feel free to submit another patch that escapes the colons in $after. The script already uses #!/bin/bash, so a "${after//:/\:}" should work. Michal