Re: [PATCH 2/8] um: Do not use SUBARCH

Richard Weinberger
2013-09-26T15:04:26Z

Am 26.09.2013 16:36, schrieb Ramkumar Ramachandra:
> Richard Weinberger wrote:
>>> Sorry for chiming in, but... what about cross compiling?
>>> SUBARCH=x86 should give you a 32-bit ia32 kernel, right?
>>
>> Correct.
>> Users expect from SUBARCH=x86 a i386 32bit UML kernel.
>
> This is an insane expectation. This is kernel convention (it has
> nothing to do with uml):

Hmm, looks like I missed commit ffee0de411, thanks for pointing that out.
Before ffee0de411 "make defconfig ARCH=x86" produced a 32bit defconfig.
Now it produces a x86_64 defconfig.

As UML is a variant of x86 it makes not much sense to do things the other
way around even if we break assumptions.

And, of course, this makes your patch valid.
Can you also please ensure that your new defconfigs are minimal?
See make savedefconfig.

Thanks,
//richard