From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:41193 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754065Ab3JBUaB (ORCPT ); Wed, 2 Oct 2013 16:30:01 -0400 Message-ID: <524C8242.2080405@suse.cz> Date: Wed, 02 Oct 2013 22:29:54 +0200 From: Michal Marek MIME-Version: 1.0 Subject: Re: [PATCH] kconfig: fix allmodconfig References: <1379805443-10945-1-git-send-email-yann.morin.1998@free.fr> <20130921232102.GC3221@free.fr> <20130926213621.GF3418@free.fr> <52455BA2.2020805@suse.cz> In-Reply-To: <52455BA2.2020805@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: "Yann E. MORIN" Cc: linux-kbuild@vger.kernel.org, Stephen Rothwell , Sam Ravnborg Dne 27.9.2013 12:19, Michal Marek napsal(a): > On 26.9.2013 23:36, Yann E. MORIN wrote: >> Hello All! >> >> On 2013-09-22 01:21 +0200, Yann E. MORIN spake thusly: >>> Stephen, All, >>> >>> Please, test this patch to fix the allmodconfig issue reported by >>> Stephen. >>> >>> From my little testing (some randconfig followed by silentoldconfig, as >>> well as allmodconfig), this patch seems to fix the issue without any >>> regression I could ientify. >>> >>> But since this is sensitive code, I'd like some feedback before this >>> gets applied. >> >> Ping? :-) >> >> I wanted to push this right after -rc3 is out. If any one has an issue >> with that patch, you've got a few days to chime in! ;-) > > It works for me, you can add my Tested-by: if you like. The only issue I > have is that a more verbose changelog is missing. Sorry, I have to retract my Tested-by. When I merge your rc-fixes branch into 3.12-rc1, I get this behavior: $ make mrproper $ make allmodconfig ... scripts/kconfig/conf --allmodconfig Kconfig # # configuration written to .config #$ make silentoldconfig scripts/kconfig/conf --silentoldconfig Kconfig * * Restart config... * (this should not happen) * * PHY Device support and infrastructure * PHY Device support and infrastructure (PHYLIB) [Y/?] y * * MII PHY device drivers * Drivers for Atheros AT803X PHYs (AT803X_PHY) [M/n/y/?] m Drivers for the AMD PHYs (AMD_PHY) [M/n/y/?] m Drivers for Marvell PHYs (MARVELL_PHY) [M/n/y/?] m Drivers for Davicom PHYs (DAVICOM_PHY) [M/n/y/?] m Drivers for Quality Semiconductor PHYs (QSEMI_PHY) [M/n/y/?] m Drivers for the Intel LXT PHYs (LXT_PHY) [M/n/y/?] m Drivers for the Cicada PHYs (CICADA_PHY) [M/n/y/?] m Drivers for the Vitesse PHYs (VITESSE_PHY) [M/n/y/?] m Drivers for SMSC PHYs (SMSC_PHY) [M/y/?] m Drivers for Broadcom PHYs (BROADCOM_PHY) [M/n/y/?] m Driver for Broadcom BCM8706 and BCM8727 PHYs (BCM87XX_PHY) [M/n/y/?] m Drivers for ICPlus PHYs (ICPLUS_PHY) [M/n/y/?] m Drivers for Realtek PHYs (REALTEK_PHY) [M/n/y/?] m Drivers for National Semiconductor PHYs (NATIONAL_PHY) [M/n/y/?] m Driver for STMicroelectronics STe10Xp PHYs (STE10XP) [M/n/y/?] m Driver for LSI ET1011C PHY (LSI_ET1011C_PHY) [M/n/y/?] m Driver for Micrel PHYs (MICREL_PHY) [M/n/y/?] m Driver for MDIO Bus/PHY emulation with fixed speed/link PHYs (FIXED_PHY) [N/y/?] (NEW) The .config generated by make allmodconfig is identical to a .config generated with plain v3.12-rc1 and thus correct. It's (silent)oldconfig that has a problem. Michal