From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:45894 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979Ab3KLIke (ORCPT ); Tue, 12 Nov 2013 03:40:34 -0500 Message-ID: <5281E97D.6090806@suse.cz> Date: Tue, 12 Nov 2013 09:40:29 +0100 From: Michal Marek MIME-Version: 1.0 Subject: Re: [PATCH 1/2] PCI: Do not use PCI ID macros in quirk names References: <1384177236-8371-1-git-send-email-mmarek@suse.cz> In-Reply-To: <1384177236-8371-1-git-send-email-mmarek@suse.cz> Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: linux-kernel@vger.kernel.org Cc: linux-kbuild@vger.kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, Andi Kleen , Joe Mario On 11.11.2013 14:40, Michal Marek wrote: > Pasting the verbatim PCI_(VENDOR|DEVICE)_* macros in the __pci_fixup_* > symbol names results in insanely long names such as > > __pci_fixup_resumePCI_VENDOR_ID_SERVERWORKSPCI_DEVICE_ID_SERVERWORKS_HT1000SBquirk_disable_broadcom_boot_interrupt > > When LTO adds its numeric suffix to such symbol, it overflows the > namebuf[KSYM_NAME_LEN] array. Use the line number instead to create "... the namebuf[KSYM_NAME_LEN] array in kernel/kallsyms.c." That way, the changelog is hopefully more clear. Michal