From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([143.182.124.21]:45005 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753532Ab3LaOjR (ORCPT ); Tue, 31 Dec 2013 09:39:17 -0500 Message-ID: <52C2D713.5050501@linux.intel.com> Date: Tue, 31 Dec 2013 06:39:15 -0800 From: Arjan van de Ven MIME-Version: 1.0 Subject: Re: [patch core/stackprotector] stackprotector: Fix build when compiler lacks support References: <1387481759-14535-3-git-send-email-keescook@chromium.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: David Rientjes , Ingo Molnar Cc: Linus Torvalds , peterz@infradead.org, Andrew Morton , linux@arm.linux.org.uk, ralf@linux-mips.org, tglx@linutronix.de, "H. Peter Anvin" , linux-kernel@vger.kernel.org, james.hogan@imgtec.com, Michal Marek , lethal@linux-sh.org, shawn.guo@linaro.org, Kees Cook , sfr@canb.auug.org.au, linux-kbuild@vger.kernel.org, linux-tip-commits@vger.kernel.org On 12/30/2013 1:37 PM, David Rientjes wrote: > 8779657d29c0 ("stackprotector: Introduce CONFIG_CC_STACKPROTECTOR_STRONG") > causes the build to break when the compiler doesn't support > -fstack-protector-strong: > > cc1: error: unrecognized command line option ‘-fstack-protector-strong’ > cc1: error: unrecognized command line option ‘-fstack-protector-strong’ > > with at least gcc 4.6.3. > > Instead of breaking the build, just warn of the failure and disable the > feature. ideally it also falls back to the less strict one, rather than not using stack protector at all...