From: Michal Marek <mmarek@suse.cz>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Kirill Tkhai <tkhai@yandex.ru>,
Michael Opdenacker <michael.opdenacker@free-electrons.com>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] Makefile, CONFIG_MODVERSIONS, ignore *.mod.c files
Date: Wed, 05 Feb 2014 16:16:25 +0100 [thread overview]
Message-ID: <52F255C9.3030600@suse.cz> (raw)
In-Reply-To: <52F253D6.2060100@redhat.com>
On 2014-02-05 16:08, Prarit Bhargava wrote:
>
>
> On 02/05/2014 10:05 AM, Michal Marek wrote:
>> On 2014-02-05 16:01, Prarit Bhargava wrote:
>>> Add *.mod.c to the RCS_FIND_IGNORE in the top-level Makefile and to the ignore
>>> list in scripts/tags.sh.
>>
>>
>> This breaks make clean, which is supposed to remove the *.mod.c files.
>>
>
> Michal,
>
> Oops. :(. So just the scripts/tags.sh needs to modified. I'll resubmit just
> that patch unless you have a better suggestion.
Please directly change the find command in find_arch_sources() and
find_include_sources(), so that the $ignore variable is really
equivalent to $RCS_FIND_IGNORE. I'm actually wondering why we do not
simply use $RCS_FIND_IGNORE in the script.
Thanks,
Michal
prev parent reply other threads:[~2014-02-05 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 15:01 [PATCH] Makefile, CONFIG_MODVERSIONS, ignore *.mod.c files Prarit Bhargava
2014-02-05 15:05 ` Michal Marek
2014-02-05 15:08 ` Prarit Bhargava
2014-02-05 15:16 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F255C9.3030600@suse.cz \
--to=mmarek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.opdenacker@free-electrons.com \
--cc=prarit@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tkhai@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox