From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:53089 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752764AbaBEPQc (ORCPT ); Wed, 5 Feb 2014 10:16:32 -0500 Message-ID: <52F255C9.3030600@suse.cz> Date: Wed, 05 Feb 2014 16:16:25 +0100 From: Michal Marek MIME-Version: 1.0 Subject: Re: [PATCH] Makefile, CONFIG_MODVERSIONS, ignore *.mod.c files References: <1391612511-9276-1-git-send-email-prarit@redhat.com> <52F2533F.2020302@suse.cz> <52F253D6.2060100@redhat.com> In-Reply-To: <52F253D6.2060100@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Prarit Bhargava Cc: linux-kernel@vger.kernel.org, Andrew Morton , Kirill Tkhai , Michael Opdenacker , Rusty Russell , linux-kbuild@vger.kernel.org On 2014-02-05 16:08, Prarit Bhargava wrote: > > > On 02/05/2014 10:05 AM, Michal Marek wrote: >> On 2014-02-05 16:01, Prarit Bhargava wrote: >>> Add *.mod.c to the RCS_FIND_IGNORE in the top-level Makefile and to the ignore >>> list in scripts/tags.sh. >> >> >> This breaks make clean, which is supposed to remove the *.mod.c files. >> > > Michal, > > Oops. :(. So just the scripts/tags.sh needs to modified. I'll resubmit just > that patch unless you have a better suggestion. Please directly change the find command in find_arch_sources() and find_include_sources(), so that the $ignore variable is really equivalent to $RCS_FIND_IGNORE. I'm actually wondering why we do not simply use $RCS_FIND_IGNORE in the script. Thanks, Michal