Re: [PATCH 5/5] x86 kbuild: LLVMLinux: More cc-options added for clang

Behan Webster
2014-02-26T01:44:19Z

On 02/25/14 17:32, H. Peter Anvin wrote:
> On 02/25/2014 05:08 PM, behanw@converseincode.com wrote:
>>
>> +# enforce no-sse for clang
>> +ifneq ($(COMPILER),clang)
>> + KBUILD_CFLAGS += $(call cc-option,-mno-sse)
>> + KBUILD_CFLAGS += $(call cc-option,-mpreferred-stack-boundary=3)
>> +endif
>> +
> I'm *very* confused. You're doing ifneq here but you're talking about
> it as if you are *adding* them for Clang, also these options are already
> added elsewhere (lines 57, 64, 86, 89) so why add them here?
Because when David Woodhouse's recent .code16 changes made it upstream
(which invalidated most of our original patch) it seems I didn't remove
this properly from our patch as well. :)

Thanks David for your patches. Thanks Peter for your sharp eyes!

Another example of why reviewing code on the mailing list works so well.

I will fix and resend.

Behan

--
Behan Webster
behanw@converseincode.com