* [PATCH] arm, kbuild: Do not define "comma" twice
@ 2013-12-13 2:37 Masahiro Yamada
2014-03-28 7:05 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2013-12-13 2:37 UTC (permalink / raw)
To: linux-kbuild; +Cc: Masahiro Yamada
We have the definition of "comma" in scripts/Kbuild.include.
We should not double it.
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
arch/arm/Makefile | 2 --
arch/arm64/Makefile | 2 --
2 files changed, 4 deletions(-)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index db50b62..60351d2 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -53,8 +53,6 @@ AS += -EL
LD += -EL
endif
-comma = ,
-
# This selects which instruction set is used.
# Note that GCC does not numerically define an architecture version
# macro, but instead defines a whole series of macros which makes
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index d90cf79..75c5527 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -24,8 +24,6 @@ KBUILD_CPPFLAGS += -mlittle-endian
AS += -EL
LD += -EL
-comma = ,
-
CHECKFLAGS += -D__aarch64__
# Default value
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm, kbuild: Do not define "comma" twice
2013-12-13 2:37 [PATCH] arm, kbuild: Do not define "comma" twice Masahiro Yamada
@ 2014-03-28 7:05 ` Masahiro Yamada
2014-03-28 10:15 ` Michal Marek
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2014-03-28 7:05 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-kbuild
Hi Michal,
Does this patch look good?
Any problem? Or should I have sent it to arm-kernel, not linux-kbuild ML?
Thanks.
Masahiro Yamada
On Fri, 13 Dec 2013 11:37:13 +0900
Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> We have the definition of "comma" in scripts/Kbuild.include.
> We should not double it.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> arch/arm/Makefile | 2 --
> arch/arm64/Makefile | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index db50b62..60351d2 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -53,8 +53,6 @@ AS += -EL
> LD += -EL
> endif
>
> -comma = ,
> -
> # This selects which instruction set is used.
> # Note that GCC does not numerically define an architecture version
> # macro, but instead defines a whole series of macros which makes
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index d90cf79..75c5527 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -24,8 +24,6 @@ KBUILD_CPPFLAGS += -mlittle-endian
> AS += -EL
> LD += -EL
>
> -comma = ,
> -
> CHECKFLAGS += -D__aarch64__
>
> # Default value
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm, kbuild: Do not define "comma" twice
2014-03-28 7:05 ` Masahiro Yamada
@ 2014-03-28 10:15 ` Michal Marek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Marek @ 2014-03-28 10:15 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kbuild
On 2014-03-28 08:05, Masahiro Yamada wrote:
> Hi Michal,
>
> Does this patch look good?
> Any problem? Or should I have sent it to arm-kernel, not linux-kbuild ML?
Hi Masariho,
I'm sorry, I missed the patch. But it's indeed a better idea to send the
patch to linux-arm-kernel.
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-28 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-13 2:37 [PATCH] arm, kbuild: Do not define "comma" twice Masahiro Yamada
2014-03-28 7:05 ` Masahiro Yamada
2014-03-28 10:15 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox