Re: [PATCH 03/32] perf tools: Kbuild source related fixies

[David Ahern <dsahern@gmail.com>]

On 6/3/14, 4:05 PM, Alexis Berlemont wrote:
> From: Jiri Olsa <jolsa@redhat.com>
>
> Fixing several sources config dependencies to allow
> separate config builds.
>
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Michal Marek <mmarek@suse.cz>
> Cc: linux-kbuild@vger.kernel.org
> Cc: Stephane Eranian <eranian@google.com>
> ---
>   tools/perf/builtin-lock.c        |  4 +++-
>   tools/perf/builtin-sched.c       |  2 ++
>   tools/perf/perf.c                |  6 ++++++
>   tools/perf/perf.h                |  2 ++
>   tools/perf/ui/browsers/scripts.c |  4 ++++
>   tools/perf/ui/setup.c            | 10 +++++++++-
>   6 files changed, 26 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index c852c7a..b255c20 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -992,9 +992,11 @@ int cmd_lock(int argc, const char **argv, const char *prefix __maybe_unused)
>   				usage_with_options(report_usage, report_options);
>   		}
>   		rc = __cmd_report(false);
> +#ifdef CONFIG_BULTIN_SCRIPT
>   	} else if (!strcmp(argv[0], "script")) {
>   		/* Aliased to 'perf script' */
> -		return cmd_script(argc, argv, prefix);
> +		rc = cmd_script(argc, argv, prefix);
> +#endif
>   	} else if (!strcmp(argv[0], "info")) {
>   		if (argc) {
>   			argc = parse_options(argc, argv,

Since you are not adding builtin-cmds.h as an included file this change 
takes away functionality. Each patch should ensure that existing options 
continue to work after the change.

ditto for all of the other changes to other files.

David