Re: [PATCH] kbuild: trivial - use tabs for code indent where possible

Michal Marek
2014-06-10T09:09:23Z

On 2014-06-10 03:53, Masahiro Yamada wrote:
> Hi Michal,
>
> On Mon, 09 Jun 2014 23:59:35 +0200
> Michal Marek <mmarek@suse.cz> wrote:
>
>> Dne 29.5.2014 07:11, Masahiro Yamada napsal(a):
>>> scripts/kconfig/zconf.l | 4 +--
>>> scripts/kconfig/zconf.y | 2 +-
>>
>> Please also update the _shipped files.
>
>
> Do you mean, fix the corresponding indents
> in zconf.lex.c_shipped and zconf.tab.c_shipped by hand?
>
> Or regenerate them with flex and bison?

Since you are patching code that is copied to the generated files
verbatim and you are not changing line numbers, it is OK to patch the
generated files by hand. Regenerating them with the exact same
flex/bison version would have the same result.

> I just tried:
>
> flex -L -Pzconf -o scripts/kconfig/zconf.lex.c_shipped scripts/kconfig/zconf.l
> bison -l -o scripts/kconfig/zconf.tab.c_shipped scripts/kconfig/zconf.y
> (Correct?)
>
> But it introduced much more diffs and I am hesitating to do it.
> The current zconf.tab.c_shipped was generated by Bison 2.5.
> But I am using Bison 3.0.2.
>
> If I need to regenerate _shipped, it would be better to do it
> in a separete patch.

If you choose to regenerate them, then it's indeed better to send two
patches.

> Anyway, I think updating indents by hand would be easier and safer.

Yeah, it probably is.

Michal