Re: [PATCH] kbuild: trivial - use tabs for code indent where possible

Masahiro Yamada
2014-06-10T01:53:21Z

Hi Michal,

On Mon, 09 Jun 2014 23:59:35 +0200
Michal Marek <mmarek@suse.cz> wrote:

> Dne 29.5.2014 07:11, Masahiro Yamada napsal(a):
> > scripts/kconfig/zconf.l | 4 +--
> > scripts/kconfig/zconf.y | 2 +-
>
> Please also update the _shipped files.

Do you mean, fix the corresponding indents
in zconf.lex.c_shipped and zconf.tab.c_shipped by hand?

Or regenerate them with flex and bison?

I just tried:

flex -L -Pzconf -o scripts/kconfig/zconf.lex.c_shipped scripts/kconfig/zconf.l
bison -l -o scripts/kconfig/zconf.tab.c_shipped scripts/kconfig/zconf.y
(Correct?)

But it introduced much more diffs and I am hesitating to do it.
The current zconf.tab.c_shipped was generated by Bison 2.5.
But I am using Bison 3.0.2.

If I need to regenerate _shipped, it would be better to do it
in a separete patch.

Anyway, I think updating indents by hand would be easier and safer.

Please advise me.

Best Regards
Masahiro Yamada