From: Michal Marek <mmarek@suse.cz>
To: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kbuild: trivial - use tabs for code indent where possible
Date: Tue, 10 Jun 2014 11:09:20 +0200 [thread overview]
Message-ID: <5396CB40.6030509@suse.cz> (raw)
In-Reply-To: <20140610105308.95F4.AA925319@jp.panasonic.com>
On 2014-06-10 03:53, Masahiro Yamada wrote:
> Hi Michal,
>
> On Mon, 09 Jun 2014 23:59:35 +0200
> Michal Marek <mmarek@suse.cz> wrote:
>
>> Dne 29.5.2014 07:11, Masahiro Yamada napsal(a):
>>> scripts/kconfig/zconf.l | 4 +--
>>> scripts/kconfig/zconf.y | 2 +-
>>
>> Please also update the _shipped files.
>
>
> Do you mean, fix the corresponding indents
> in zconf.lex.c_shipped and zconf.tab.c_shipped by hand?
>
> Or regenerate them with flex and bison?
Since you are patching code that is copied to the generated files
verbatim and you are not changing line numbers, it is OK to patch the
generated files by hand. Regenerating them with the exact same
flex/bison version would have the same result.
> I just tried:
>
> flex -L -Pzconf -o scripts/kconfig/zconf.lex.c_shipped scripts/kconfig/zconf.l
> bison -l -o scripts/kconfig/zconf.tab.c_shipped scripts/kconfig/zconf.y
> (Correct?)
>
> But it introduced much more diffs and I am hesitating to do it.
> The current zconf.tab.c_shipped was generated by Bison 2.5.
> But I am using Bison 3.0.2.
>
> If I need to regenerate _shipped, it would be better to do it
> in a separete patch.
If you choose to regenerate them, then it's indeed better to send two
patches.
> Anyway, I think updating indents by hand would be easier and safer.
Yeah, it probably is.
Michal
next prev parent reply other threads:[~2014-06-10 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 5:11 [PATCH] kbuild: trivial - use tabs for code indent where possible Masahiro Yamada
2014-06-09 21:59 ` Michal Marek
2014-06-10 1:53 ` Masahiro Yamada
2014-06-10 9:09 ` Michal Marek [this message]
2014-06-10 10:10 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5396CB40.6030509@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox