From: Michal Marek <mmarek@suse.cz>
To: Fathi Boudra <fathi.boudra@linaro.org>,
Ben Hutchings <ben@decadent.org.uk>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>,
Maximilian Attems <maks@debian.org>
Subject: Re: [PATCH v2] builddeb: fix missing headers in linux-headers package
Date: Fri, 13 Jun 2014 13:39:33 +0200 [thread overview]
Message-ID: <539AE2F5.30301@suse.cz> (raw)
In-Reply-To: <1397562708-7531-1-git-send-email-fathi.boudra@linaro.org>
Dne 15.4.2014 13:51, Fathi Boudra napsal(a):
> The kernel headers package (linux-headers) doesn't include several
> header files required to build out-of-tree modules.
>
> It makes the package unusable on e.g. ARM architecture:
> /usr/src/linux-headers-3.14.0/arch/arm/include/asm/memory.h:24:25:
> fatal error: mach/memory.h: No such file or directory
> #include <mach/memory.h>
> ^
> compilation terminated.
>
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> ---
> Changes from v1:
> - add missing module.lds, mips/Kbuild.platforms and Platform files
> - generically look for all include directories in arch/$SRCARCH
Ben, is this version OK to merge? Does the package now match the
official Debian ones?
Thanks,
Michal
> scripts/package/builddeb | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index f46e4dd..42b1e20 100644
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -287,9 +287,11 @@ EOF
>
> fi
>
> -# Build header package
> +# Build kernel header package
> (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > "$objtree/debian/hdrsrcfiles")
> (cd $srctree; find arch/$SRCARCH/include include scripts -type f >> "$objtree/debian/hdrsrcfiles")
> +(cd $srctree; find arch/$SRCARCH -name module.lds -o -name Kbuild.platforms -o -name Platform >> "$objtree/debian/hdrsrcfiles")
> +(cd $srctree; find $(find arch/$SRCARCH -name include -o -name scripts -type d) -type f >> "$objtree/debian/hdrsrcfiles")
> (cd $objtree; find arch/$SRCARCH/include Module.symvers include scripts -type f >> "$objtree/debian/hdrobjfiles")
> destdir=$kernel_headers_dir/usr/src/linux-headers-$version
> mkdir -p "$destdir"
next prev parent reply other threads:[~2014-06-13 11:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 11:51 [PATCH v2] builddeb: fix missing headers in linux-headers package Fathi Boudra
2014-04-25 6:12 ` Fathi Boudra
2014-05-09 6:42 ` Fathi Boudra
2014-06-13 5:14 ` Fathi Boudra
2014-06-13 11:39 ` Michal Marek [this message]
2014-06-15 15:19 ` Ben Hutchings
2014-06-18 19:37 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539AE2F5.30301@suse.cz \
--to=mmarek@suse.cz \
--cc=ben@decadent.org.uk \
--cc=fathi.boudra@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=maks@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox