* [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-)
@ 2014-06-06 1:43 Masahiro Yamada
2014-06-06 13:30 ` Sam Ravnborg
2014-06-12 8:24 ` Michal Marek
0 siblings, 2 replies; 10+ messages in thread
From: Masahiro Yamada @ 2014-06-06 1:43 UTC (permalink / raw)
To: linux-kbuild; +Cc: Masahiro Yamada
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
scripts/Makefile.clean | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean
index 686cb0d..a651cee 100644
--- a/scripts/Makefile.clean
+++ b/scripts/Makefile.clean
@@ -40,8 +40,8 @@ subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn))
# build a list of files to remove, usually relative to the current
# directory
-__clean-files := $(extra-y) $(always) \
- $(targets) $(clean-files) \
+__clean-files := $(extra-y) $(extra-m) $(extra-) \
+ $(always) $(targets) $(clean-files) \
$(host-progs) \
$(hostprogs-y) $(hostprogs-m) $(hostprogs-)
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-)
2014-06-06 1:43 [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-) Masahiro Yamada
@ 2014-06-06 13:30 ` Sam Ravnborg
2014-06-12 5:46 ` Masahiro Yamada
2014-06-12 8:24 ` Michal Marek
1 sibling, 1 reply; 10+ messages in thread
From: Sam Ravnborg @ 2014-06-06 13:30 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kbuild
On Fri, Jun 06, 2014 at 10:43:55AM +0900, Masahiro Yamada wrote:
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-)
2014-06-06 13:30 ` Sam Ravnborg
@ 2014-06-12 5:46 ` Masahiro Yamada
0 siblings, 0 replies; 10+ messages in thread
From: Masahiro Yamada @ 2014-06-12 5:46 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-kbuild, Sam Ravnborg
Hi Michal,
Reminder, just in case.
If possible, please consider to include this patch in GIT-PULL.
On Fri, 6 Jun 2014 15:30:23 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> On Fri, Jun 06, 2014 at 10:43:55AM +0900, Masahiro Yamada wrote:
> > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-)
2014-06-06 1:43 [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-) Masahiro Yamada
2014-06-06 13:30 ` Sam Ravnborg
@ 2014-06-12 8:24 ` Michal Marek
2014-06-12 8:40 ` Masahiro Yamada
2014-06-18 19:53 ` Michal Marek
1 sibling, 2 replies; 10+ messages in thread
From: Michal Marek @ 2014-06-12 8:24 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kbuild
Dne 6.6.2014 03:43, Masahiro Yamada napsal(a):
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> scripts/Makefile.clean | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean
> index 686cb0d..a651cee 100644
> --- a/scripts/Makefile.clean
> +++ b/scripts/Makefile.clean
> @@ -40,8 +40,8 @@ subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn))
> # build a list of files to remove, usually relative to the current
> # directory
>
> -__clean-files := $(extra-y) $(always) \
> - $(targets) $(clean-files) \
> +__clean-files := $(extra-y) $(extra-m) $(extra-) \
> + $(always) $(targets) $(clean-files) \
Do you have an example where generated files are left in the tree after
make clean? This should go into the changelog.
Dne 12.6.2014 07:46, Masahiro Yamada napsal(a):> Hi Michal,
> If possible, please consider to include this patch in GIT-PULL.
Sorry, I need to do a cut off at some point :). I'll merge it right
after the merge window. If you provide a reproducer in the changelog,
I'll send it to Linus for the next -rc.
Michal
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-)
2014-06-12 8:24 ` Michal Marek
@ 2014-06-12 8:40 ` Masahiro Yamada
2014-06-12 8:41 ` Michal Marek
2014-06-18 19:53 ` Michal Marek
1 sibling, 1 reply; 10+ messages in thread
From: Masahiro Yamada @ 2014-06-12 8:40 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-kbuild
Hi Michal,
> Dne 12.6.2014 07:46, Masahiro Yamada napsal(a):> Hi Michal,
> > If possible, please consider to include this patch in GIT-PULL.
>
> Sorry, I need to do a cut off at some point :). I'll merge it right
> after the merge window. If you provide a reproducer in the changelog,
> I'll send it to Linus for the next -rc.
>
I understand.
Sorry for bothering you when you are busy.
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-)
2014-06-12 8:40 ` Masahiro Yamada
@ 2014-06-12 8:41 ` Michal Marek
0 siblings, 0 replies; 10+ messages in thread
From: Michal Marek @ 2014-06-12 8:41 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kbuild
Dne 12.6.2014 10:40, Masahiro Yamada napsal(a):
> Hi Michal,
>
>
>> Dne 12.6.2014 07:46, Masahiro Yamada napsal(a):> Hi Michal,
>>> If possible, please consider to include this patch in GIT-PULL.
>>
>> Sorry, I need to do a cut off at some point :). I'll merge it right
>> after the merge window. If you provide a reproducer in the changelog,
>> I'll send it to Linus for the next -rc.
>>
>
> I understand.
> Sorry for bothering you when you are busy.
That's not a problem. It's more that Linus is usually not happy to see
some last minute commits in the pull request.
Michal
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-)
2014-06-12 8:24 ` Michal Marek
2014-06-12 8:40 ` Masahiro Yamada
@ 2014-06-18 19:53 ` Michal Marek
2014-06-20 12:22 ` Masahiro Yamada
1 sibling, 1 reply; 10+ messages in thread
From: Michal Marek @ 2014-06-18 19:53 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kbuild
Dne 12.6.2014 10:24, Michal Marek napsal(a):
> Dne 6.6.2014 03:43, Masahiro Yamada napsal(a):
>> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
>> ---
>> scripts/Makefile.clean | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean
>> index 686cb0d..a651cee 100644
>> --- a/scripts/Makefile.clean
>> +++ b/scripts/Makefile.clean
>> @@ -40,8 +40,8 @@ subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn))
>> # build a list of files to remove, usually relative to the current
>> # directory
>>
>> -__clean-files := $(extra-y) $(always) \
>> - $(targets) $(clean-files) \
>> +__clean-files := $(extra-y) $(extra-m) $(extra-) \
>> + $(always) $(targets) $(clean-files) \
>
> Do you have an example where generated files are left in the tree after
> make clean? This should go into the changelog.
Hi Masahiro,
do you have a reproducer, i.e. an example where make clean leaves
generated files in the tree?
Thanks,
Michal
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-)
2014-06-18 19:53 ` Michal Marek
@ 2014-06-20 12:22 ` Masahiro Yamada
2014-06-20 13:23 ` Michal Marek
0 siblings, 1 reply; 10+ messages in thread
From: Masahiro Yamada @ 2014-06-20 12:22 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-kbuild
Hi Michal,
On Wed, 18 Jun 2014 21:53:02 +0200
Michal Marek <mmarek@suse.cz> wrote:
> Dne 12.6.2014 10:24, Michal Marek napsal(a):
> > Dne 6.6.2014 03:43, Masahiro Yamada napsal(a):
> >> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> >> ---
> >> scripts/Makefile.clean | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean
> >> index 686cb0d..a651cee 100644
> >> --- a/scripts/Makefile.clean
> >> +++ b/scripts/Makefile.clean
> >> @@ -40,8 +40,8 @@ subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn))
> >> # build a list of files to remove, usually relative to the current
> >> # directory
> >>
> >> -__clean-files := $(extra-y) $(always) \
> >> - $(targets) $(clean-files) \
> >> +__clean-files := $(extra-y) $(extra-m) $(extra-) \
> >> + $(always) $(targets) $(clean-files) \
> >
> > Do you have an example where generated files are left in the tree after
> > make clean? This should go into the changelog.
>
> Hi Masahiro,
>
> do you have a reproducer, i.e. an example where make clean leaves
> generated files in the tree?
No, I don't.
I thought
arch/powerpc/kernel/Makefile is using
extra-$(CONFIG_...) += ...
but *.o files are simply cleaned-up. So this isn't the case.
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-)
2014-06-20 12:22 ` Masahiro Yamada
@ 2014-06-20 13:23 ` Michal Marek
2014-07-03 20:55 ` Michal Marek
0 siblings, 1 reply; 10+ messages in thread
From: Michal Marek @ 2014-06-20 13:23 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kbuild
Dne 20.6.2014 14:22, Masahiro Yamada napsal(a):
> Hi Michal,
>
>
> On Wed, 18 Jun 2014 21:53:02 +0200
> Michal Marek <mmarek@suse.cz> wrote:
>
>> Dne 12.6.2014 10:24, Michal Marek napsal(a):
>>> Dne 6.6.2014 03:43, Masahiro Yamada napsal(a):
>>>> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
>>>> ---
>>>> scripts/Makefile.clean | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean
>>>> index 686cb0d..a651cee 100644
>>>> --- a/scripts/Makefile.clean
>>>> +++ b/scripts/Makefile.clean
>>>> @@ -40,8 +40,8 @@ subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn))
>>>> # build a list of files to remove, usually relative to the current
>>>> # directory
>>>>
>>>> -__clean-files := $(extra-y) $(always) \
>>>> - $(targets) $(clean-files) \
>>>> +__clean-files := $(extra-y) $(extra-m) $(extra-) \
>>>> + $(always) $(targets) $(clean-files) \
>>>
>>> Do you have an example where generated files are left in the tree after
>>> make clean? This should go into the changelog.
>>
>> Hi Masahiro,
>>
>> do you have a reproducer, i.e. an example where make clean leaves
>> generated files in the tree?
>
> No, I don't.
>
> I thought
> arch/powerpc/kernel/Makefile is using
> extra-$(CONFIG_...) += ...
> but *.o files are simply cleaned-up. So this isn't the case.
OK, so there is no urgent need to add this to 'rc-fixes'. I'll queue it
up in 'kbuild' for 3.17-rc1.
Thanks,
Michal
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-)
2014-06-20 13:23 ` Michal Marek
@ 2014-07-03 20:55 ` Michal Marek
0 siblings, 0 replies; 10+ messages in thread
From: Michal Marek @ 2014-07-03 20:55 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kbuild
Dne 20.6.2014 15:23, Michal Marek napsal(a):
> Dne 20.6.2014 14:22, Masahiro Yamada napsal(a):
>> Hi Michal,
>>
>>
>> On Wed, 18 Jun 2014 21:53:02 +0200
>> Michal Marek <mmarek@suse.cz> wrote:
>>
>>> Dne 12.6.2014 10:24, Michal Marek napsal(a):
>>>> Dne 6.6.2014 03:43, Masahiro Yamada napsal(a):
>>>>> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
>>>>> ---
>>>>> scripts/Makefile.clean | 4 ++--
>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean
>>>>> index 686cb0d..a651cee 100644
>>>>> --- a/scripts/Makefile.clean
>>>>> +++ b/scripts/Makefile.clean
>>>>> @@ -40,8 +40,8 @@ subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn))
>>>>> # build a list of files to remove, usually relative to the current
>>>>> # directory
>>>>>
>>>>> -__clean-files := $(extra-y) $(always) \
>>>>> - $(targets) $(clean-files) \
>>>>> +__clean-files := $(extra-y) $(extra-m) $(extra-) \
>>>>> + $(always) $(targets) $(clean-files) \
>>>>
>>>> Do you have an example where generated files are left in the tree after
>>>> make clean? This should go into the changelog.
>>>
>>> Hi Masahiro,
>>>
>>> do you have a reproducer, i.e. an example where make clean leaves
>>> generated files in the tree?
>>
>> No, I don't.
>>
>> I thought
>> arch/powerpc/kernel/Makefile is using
>> extra-$(CONFIG_...) += ...
>> but *.o files are simply cleaned-up. So this isn't the case.
>
> OK, so there is no urgent need to add this to 'rc-fixes'. I'll queue it
> up in 'kbuild' for 3.17-rc1.
It's in kbuild.git#kbuild now.
Michal
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-07-03 20:55 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-06 1:43 [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-) Masahiro Yamada
2014-06-06 13:30 ` Sam Ravnborg
2014-06-12 5:46 ` Masahiro Yamada
2014-06-12 8:24 ` Michal Marek
2014-06-12 8:40 ` Masahiro Yamada
2014-06-12 8:41 ` Michal Marek
2014-06-18 19:53 ` Michal Marek
2014-06-20 12:22 ` Masahiro Yamada
2014-06-20 13:23 ` Michal Marek
2014-07-03 20:55 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox