Re: [PATCH] kbuild: document KBUILD_SHELL

[Michal Marek <mmarek@suse.cz>]

Dne 26.6.2014 04:02, Masahiro Yamada napsal(a):
> On Mon, 9 Jun 2014 13:40:10 +0200
> Sam Ravnborg <sam@ravnborg.org> wrote:
>> All shell scripts that are invoked with $(CONFIG_SHELL) must be sh-compatible,
>> or in practice dash compatible as well as bash compatible.
>> The preference is bash as expressed with the above code.
> 
> 
> I notice at least two files (scripts/coccicheck and scripts/mkuboot.sh)
> have shebang "#!/bin/bash" even though they are invoked with $(CONFIG_SHELL).
> 
> Should we change them to "#!/bin/sh" ?

Sorry for the late reply.

If we are going to change the CONFIG_SHELL (KBUILD_SHELL) variable to
/bin/sh, then yes, please change them to /bin/sh and make them dash
compatible.


> In that case, we also have to modify some lines where bash-extension
> is used.
> 
> COCCIINCLUDE=${LINUXINCLUDE//-I/-I }
> COCCIINCLUDE=${COCCIINCLUDE//-include/-I}
> 
> I think fixing them is not difficult.

Right, nothing a simple sed call wouldn't fix.

Thanks,
Michal