* Regression: firmware: Simplify directory creation + b43 = fails to build
@ 2014-06-18 8:46 Ronald
2014-06-18 14:33 ` Michal Marek
0 siblings, 1 reply; 9+ messages in thread
From: Ronald @ 2014-06-18 8:46 UTC (permalink / raw)
To: linux-kbuild, linux-kernel, mmarek
Dear kernel developers,
Latest git HEAD (from Torvalds):
CC drivers/base/firmware_class.o
LD drivers/base/built-in.o
MK_FW firmware/b43/ucode5.fw.gen.S
/bin/sh: firmware/b43/ucode5.fw.gen.S: Bestand of map bestaat niet
(file or directory does not exist, it should not have the .gen.S
suffix)
/bin/sh: firmware/b43/ucode5.fw.gen.S: Bestand of map bestaat niet
... snip ...
/bin/sh: firmware/b43/ucode5.fw.gen.S: Bestand of map bestaat niet
firmware/Makefile:185: recept voor doel 'firmware/b43/ucode5.fw.gen.S'
is mislukt
make[1]: *** [firmware/b43/ucode5.fw.gen.S] Fout 1
Makefile:893: recept voor doel 'firmware' is mislukt
make: *** [firmware] Fout 2
make: *** Wachten op onvoltooide taken...
==> git revert 5180d5f
[bleed 55a169f] Revert "firmware: Simplify directory creation"
2 files changed, 38 insertions(+), 16 deletions(-)
09:57 ronald@Charlie /usr/src/linux :)
==> time make -j2
... snip ...
LD drivers/base/built-in.o
MKDIR firmware/b43/
MK_FW firmware/b43/ucode5.fw.gen.S
MK_FW firmware/b43/b0g0initvals5.fw.gen.S
MK_FW firmware/b43/b0g0bsinitvals5.fw.gen.S
MK_FW firmware/b43/pcm5.fw.gen.S
AS firmware/b43/ucode5.fw.gen.o
AS firmware/b43/b0g0initvals5.fw.gen.o
AS firmware/b43/b0g0bsinitvals5.fw.gen.o
AS firmware/b43/pcm5.fw.gen.o
LD firmware/built-in.o
If you require more info, please let me know.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Regression: firmware: Simplify directory creation + b43 = fails to build
2014-06-18 8:46 Regression: firmware: Simplify directory creation + b43 = fails to build Ronald
@ 2014-06-18 14:33 ` Michal Marek
2014-06-18 16:25 ` Ronald
0 siblings, 1 reply; 9+ messages in thread
From: Michal Marek @ 2014-06-18 14:33 UTC (permalink / raw)
To: Ronald; +Cc: linux-kbuild, linux-kernel
Dne 18.6.2014 10:46, Ronald napsal(a):
> Dear kernel developers,
>
> Latest git HEAD (from Torvalds):
>
> CC drivers/base/firmware_class.o
> LD drivers/base/built-in.o
> MK_FW firmware/b43/ucode5.fw.gen.S
> /bin/sh: firmware/b43/ucode5.fw.gen.S: Bestand of map bestaat niet
> (file or directory does not exist, it should not have the .gen.S
> suffix)
> /bin/sh: firmware/b43/ucode5.fw.gen.S: Bestand of map bestaat niet
> ... snip ...
> /bin/sh: firmware/b43/ucode5.fw.gen.S: Bestand of map bestaat niet
> firmware/Makefile:185: recept voor doel 'firmware/b43/ucode5.fw.gen.S'
> is mislukt
> make[1]: *** [firmware/b43/ucode5.fw.gen.S] Fout 1
> Makefile:893: recept voor doel 'firmware' is mislukt
> make: *** [firmware] Fout 2
> make: *** Wachten op onvoltooide taken...
Where does firmware/b43 come from?
Thanks,
Michal
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Regression: firmware: Simplify directory creation + b43 = fails to build
2014-06-18 14:33 ` Michal Marek
@ 2014-06-18 16:25 ` Ronald
2014-07-07 19:02 ` Torsten Kaiser
0 siblings, 1 reply; 9+ messages in thread
From: Ronald @ 2014-06-18 16:25 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-kbuild, linux-kernel
From my .config
==> cat /usr/src/config | grep -i b43
CONFIG_EXTRA_FIRMWARE="b43/ucode5.fw b43/b0g0initvals5.fw
b43/b0g0bsinitvals5.fw b43/pcm5.fw"
... snip ...
2014-06-18 16:33 GMT+02:00 Michal Marek <mmarek@suse.cz>:
> Dne 18.6.2014 10:46, Ronald napsal(a):
>> Dear kernel developers,
>>
>> Latest git HEAD (from Torvalds):
>>
>> CC drivers/base/firmware_class.o
>> LD drivers/base/built-in.o
>> MK_FW firmware/b43/ucode5.fw.gen.S
>> /bin/sh: firmware/b43/ucode5.fw.gen.S: Bestand of map bestaat niet
>> (file or directory does not exist, it should not have the .gen.S
>> suffix)
>> /bin/sh: firmware/b43/ucode5.fw.gen.S: Bestand of map bestaat niet
>> ... snip ...
>> /bin/sh: firmware/b43/ucode5.fw.gen.S: Bestand of map bestaat niet
>> firmware/Makefile:185: recept voor doel 'firmware/b43/ucode5.fw.gen.S'
>> is mislukt
>> make[1]: *** [firmware/b43/ucode5.fw.gen.S] Fout 1
>> Makefile:893: recept voor doel 'firmware' is mislukt
>> make: *** [firmware] Fout 2
>> make: *** Wachten op onvoltooide taken...
>
> Where does firmware/b43 come from?
>
> Thanks,
> Michal
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Regression: firmware: Simplify directory creation + b43 = fails to build
2014-06-18 16:25 ` Ronald
@ 2014-07-07 19:02 ` Torsten Kaiser
2014-07-08 12:09 ` Michal Marek
2014-07-08 12:47 ` [PATCH] firmware: Create directories for external firmware Michal Marek
0 siblings, 2 replies; 9+ messages in thread
From: Torsten Kaiser @ 2014-07-07 19:02 UTC (permalink / raw)
To: Ronald; +Cc: Michal Marek, linux-kbuild, linux-kernel@vger.kernel.org
On Wed, Jun 18, 2014 at 6:25 PM, Ronald <ronald645@gmail.com> wrote:
> From my .config
>
> ==> cat /usr/src/config | grep -i b43
> CONFIG_EXTRA_FIRMWARE="b43/ucode5.fw b43/b0g0initvals5.fw
> b43/b0g0bsinitvals5.fw b43/pcm5.fw"
> ... snip ...
That might be rather later, but I seem to have the same problem:
CHK kernel/config_data.h
MK_FW firmware/amd-ucode/microcode_amd.bin.gen.S
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
firmware/Makefile:185: recipe for target
'firmware/amd-ucode/microcode_amd.bin.gen.S' failed
make[1]: *** [firmware/amd-ucode/microcode_amd.bin.gen.S] Error 1
Makefile:896: recipe for target 'firmware' failed
make: *** [firmware] Error 2
The directory firmware/amd-ucode does not exist in the kernel source
tree, but my .config seems to need it:
CONFIG_EXTRA_FIRMWARE="radeon/R700_rlc.bin radeon/RV710_uvd.bin
radeon/RV730_smc.bin amd-ucode/microcode_amd.bin"
CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware"
Just doing a "mkdir firmware/amd-ucode" lets the build continue and I
get a working 3.16 kernel.
With 3.15 and earlier I never had a problem with this, but 3.16-rc4
just failed with above message.
Do you need my full .config or any other information about my system?
I would be happy to provide that and/or test a patch.
Thanks for looking into this!
Torsten
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Regression: firmware: Simplify directory creation + b43 = fails to build
2014-07-07 19:02 ` Torsten Kaiser
@ 2014-07-08 12:09 ` Michal Marek
2014-07-08 12:47 ` [PATCH] firmware: Create directories for external firmware Michal Marek
1 sibling, 0 replies; 9+ messages in thread
From: Michal Marek @ 2014-07-08 12:09 UTC (permalink / raw)
To: Torsten Kaiser, Ronald; +Cc: linux-kbuild, linux-kernel@vger.kernel.org
On 2014-07-07 21:02, Torsten Kaiser wrote:
> On Wed, Jun 18, 2014 at 6:25 PM, Ronald <ronald645@gmail.com> wrote:
>> From my .config
>>
>> ==> cat /usr/src/config | grep -i b43
>> CONFIG_EXTRA_FIRMWARE="b43/ucode5.fw b43/b0g0initvals5.fw
>> b43/b0g0bsinitvals5.fw b43/pcm5.fw"
>> ... snip ...
>
> That might be rather later, but I seem to have the same problem:
> CHK kernel/config_data.h
> MK_FW firmware/amd-ucode/microcode_amd.bin.gen.S
> /bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
> [...]
> The directory firmware/amd-ucode does not exist in the kernel source
> tree, but my .config seems to need it:
> CONFIG_EXTRA_FIRMWARE="radeon/R700_rlc.bin radeon/RV710_uvd.bin
> radeon/RV730_smc.bin amd-ucode/microcode_amd.bin"
> CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware"
>
> Just doing a "mkdir firmware/amd-ucode" lets the build continue and I
> get a working 3.16 kernel.
>
> With 3.15 and earlier I never had a problem with this, but 3.16-rc4
> just failed with above message.
>
> Do you need my full .config or any other information about my system?
That's not needed, I can reproduce the failure now as well.
Michal
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] firmware: Create directories for external firmware
2014-07-07 19:02 ` Torsten Kaiser
2014-07-08 12:09 ` Michal Marek
@ 2014-07-08 12:47 ` Michal Marek
[not found] ` <CAF1_xX19AwepGJLJOcn_m+OaU3kk9N9d+M2v_YzzPg-M2cdrPQ@mail.gmail.com>
2014-07-08 18:03 ` Torsten Kaiser
1 sibling, 2 replies; 9+ messages in thread
From: Michal Marek @ 2014-07-08 12:47 UTC (permalink / raw)
To: Torsten Kaiser, Ronald; +Cc: linux-kbuild, linux-kernel
Commit 5180d5f4 ("firmware: Simplify directory creation") broke
including firmware specified in CONFIG_EXTRA_FIRMWARE:
MK_FW firmware/amd-ucode/microcode_amd.bin.gen.S
/bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
...
firmware/Makefile:185: recipe for target
'firmware/amd-ucode/microcode_amd.bin.gen.S' failed
It works with O= builds, because the directory is created by
Makefile.build. Create the directory in firmware/Makefile in non-O
builds.
Reported-by: Ronald <ronald645@gmail.com>
Reported-by: Torsten Kaiser <just.for.lkml@googlemail.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>
---
Can you try this patch?
Ronald, can you tell me your full name for the Reported-by: line?
Thanks.
---
firmware/Makefile | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/firmware/Makefile b/firmware/Makefile
index 5747417..0862d34 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -219,6 +219,12 @@ $(obj)/%.fw: $(obj)/%.H16 $(ihex2fw_dep)
obj-y += $(patsubst %,%.gen.o, $(fw-external-y))
obj-$(CONFIG_FIRMWARE_IN_KERNEL) += $(patsubst %,%.gen.o, $(fw-shipped-y))
+ifeq ($(KBUILD_SRC),)
+# Makefile.build only creates subdirectories for O= builds, but external
+# firmware might live outside the kernel source tree
+_dummy := $(foreach d,$(addprefix $(obj)/,$(dir $(fw-external-y))), $(shell [ -d $(d) ] || mkdir -p $(d)))
+endif
+
# Remove .S files and binaries created from ihex
# (during 'make clean' .config isn't included so they're all in $(fw-shipped-))
targets := $(fw-shipped-) $(patsubst $(obj)/%,%, \
--
1.8.4.5
^ permalink raw reply related [flat|nested] 9+ messages in thread[parent not found: <CAF1_xX19AwepGJLJOcn_m+OaU3kk9N9d+M2v_YzzPg-M2cdrPQ@mail.gmail.com>]
* Re: [PATCH] firmware: Create directories for external firmware
[not found] ` <CAF1_xX19AwepGJLJOcn_m+OaU3kk9N9d+M2v_YzzPg-M2cdrPQ@mail.gmail.com>
@ 2014-07-08 15:19 ` Ronald
2014-07-08 16:29 ` Ronald
0 siblings, 1 reply; 9+ messages in thread
From: Ronald @ 2014-07-08 15:19 UTC (permalink / raw)
To: Michal Marek; +Cc: Torsten Kaiser, linux-kbuild, linux-kernel
2014-07-08 17:18 GMT+02:00 Ronald <ronald645@gmail.com>:
> My full name is 'Ronald Uitermark'.
>
> I will try this patch tonight.
>
>
> 2014-07-08 14:47 GMT+02:00 Michal Marek <mmarek@suse.cz>:
>
>> Commit 5180d5f4 ("firmware: Simplify directory creation") broke
>> including firmware specified in CONFIG_EXTRA_FIRMWARE:
>>
>> MK_FW firmware/amd-ucode/microcode_amd.bin.gen.S
>> /bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or
>> directory
>> ...
>> firmware/Makefile:185: recipe for target
>> 'firmware/amd-ucode/microcode_amd.bin.gen.S' failed
>>
>> It works with O= builds, because the directory is created by
>> Makefile.build. Create the directory in firmware/Makefile in non-O
>> builds.
>>
>> Reported-by: Ronald <ronald645@gmail.com>
>> Reported-by: Torsten Kaiser <just.for.lkml@googlemail.com>
>> Signed-off-by: Michal Marek <mmarek@suse.cz>
>> ---
>>
>> Can you try this patch?
>>
>> Ronald, can you tell me your full name for the Reported-by: line?
>>
>> Thanks.
>> ---
>>
>> firmware/Makefile | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/firmware/Makefile b/firmware/Makefile
>> index 5747417..0862d34 100644
>> --- a/firmware/Makefile
>> +++ b/firmware/Makefile
>> @@ -219,6 +219,12 @@ $(obj)/%.fw: $(obj)/%.H16 $(ihex2fw_dep)
>> obj-y += $(patsubst %,%.gen.o,
>> $(fw-external-y))
>> obj-$(CONFIG_FIRMWARE_IN_KERNEL) += $(patsubst %,%.gen.o,
>> $(fw-shipped-y))
>>
>> +ifeq ($(KBUILD_SRC),)
>> +# Makefile.build only creates subdirectories for O= builds, but external
>> +# firmware might live outside the kernel source tree
>> +_dummy := $(foreach d,$(addprefix $(obj)/,$(dir $(fw-external-y))),
>> $(shell [ -d $(d) ] || mkdir -p $(d)))
>> +endif
>> +
>> # Remove .S files and binaries created from ihex
>> # (during 'make clean' .config isn't included so they're all in
>> $(fw-shipped-))
>> targets := $(fw-shipped-) $(patsubst $(obj)/%,%, \
>> --
>> 1.8.4.5
>>
>
(resend for flat text mode, sorry for the dupe which included top posting)
My full name is 'Ronald Uitermark'.
I will try this patch tonight.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] firmware: Create directories for external firmware
2014-07-08 15:19 ` Ronald
@ 2014-07-08 16:29 ` Ronald
0 siblings, 0 replies; 9+ messages in thread
From: Ronald @ 2014-07-08 16:29 UTC (permalink / raw)
To: Michal Marek; +Cc: Torsten Kaiser, linux-kbuild, linux-kernel
>> 2014-07-08 14:47 GMT+02:00 Michal Marek <mmarek@suse.cz>:
>>
>>> Commit 5180d5f4 ("firmware: Simplify directory creation") broke
>>> including firmware specified in CONFIG_EXTRA_FIRMWARE:
>>>
>>> MK_FW firmware/amd-ucode/microcode_amd.bin.gen.S
>>> /bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or
>>> directory
>>> ...
>>> firmware/Makefile:185: recipe for target
>>> 'firmware/amd-ucode/microcode_amd.bin.gen.S' failed
>>>
>>> It works with O= builds, because the directory is created by
>>> Makefile.build. Create the directory in firmware/Makefile in non-O
>>> builds.
>>>
>>> Reported-by: Ronald <ronald645@gmail.com>
>>> Reported-by: Torsten Kaiser <just.for.lkml@googlemail.com>
>>> Signed-off-by: Michal Marek <mmarek@suse.cz>
>>> ---
>>>
>>> Can you try this patch?
>>>
>>> Ronald, can you tell me your full name for the Reported-by: line?
>>>
>>> Thanks.
>>> ---
>>>
>>> firmware/Makefile | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/firmware/Makefile b/firmware/Makefile
>>> index 5747417..0862d34 100644
>>> --- a/firmware/Makefile
>>> +++ b/firmware/Makefile
>>> @@ -219,6 +219,12 @@ $(obj)/%.fw: $(obj)/%.H16 $(ihex2fw_dep)
>>> obj-y += $(patsubst %,%.gen.o,
>>> $(fw-external-y))
>>> obj-$(CONFIG_FIRMWARE_IN_KERNEL) += $(patsubst %,%.gen.o,
>>> $(fw-shipped-y))
>>>
>>> +ifeq ($(KBUILD_SRC),)
>>> +# Makefile.build only creates subdirectories for O= builds, but external
>>> +# firmware might live outside the kernel source tree
>>> +_dummy := $(foreach d,$(addprefix $(obj)/,$(dir $(fw-external-y))),
>>> $(shell [ -d $(d) ] || mkdir -p $(d)))
>>> +endif
>>> +
>>> # Remove .S files and binaries created from ihex
>>> # (during 'make clean' .config isn't included so they're all in
>>> $(fw-shipped-))
>>> targets := $(fw-shipped-) $(patsubst $(obj)/%,%, \
>>> --
>>> 1.8.4.5
I can confirm that this patch on top of current HEAD fixes the issue.
Thanks a ton!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] firmware: Create directories for external firmware
2014-07-08 12:47 ` [PATCH] firmware: Create directories for external firmware Michal Marek
[not found] ` <CAF1_xX19AwepGJLJOcn_m+OaU3kk9N9d+M2v_YzzPg-M2cdrPQ@mail.gmail.com>
@ 2014-07-08 18:03 ` Torsten Kaiser
1 sibling, 0 replies; 9+ messages in thread
From: Torsten Kaiser @ 2014-07-08 18:03 UTC (permalink / raw)
To: Michal Marek; +Cc: Ronald, linux-kbuild, linux-kernel@vger.kernel.org
On Tue, Jul 8, 2014 at 2:47 PM, Michal Marek <mmarek@suse.cz> wrote:
> Commit 5180d5f4 ("firmware: Simplify directory creation") broke
> including firmware specified in CONFIG_EXTRA_FIRMWARE:
>
> MK_FW firmware/amd-ucode/microcode_amd.bin.gen.S
> /bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or directory
> ...
> firmware/Makefile:185: recipe for target
> 'firmware/amd-ucode/microcode_amd.bin.gen.S' failed
>
> It works with O= builds, because the directory is created by
> Makefile.build. Create the directory in firmware/Makefile in non-O
> builds.
>
> Reported-by: Ronald <ronald645@gmail.com>
> Reported-by: Torsten Kaiser <just.for.lkml@googlemail.com>
> Signed-off-by: Michal Marek <mmarek@suse.cz>
> ---
>
> Can you try this patch?
Works fine for me.
Thanks for the quick patch!
Torsten
> Ronald, can you tell me your full name for the Reported-by: line?
>
> Thanks.
> ---
>
> firmware/Makefile | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/firmware/Makefile b/firmware/Makefile
> index 5747417..0862d34 100644
> --- a/firmware/Makefile
> +++ b/firmware/Makefile
> @@ -219,6 +219,12 @@ $(obj)/%.fw: $(obj)/%.H16 $(ihex2fw_dep)
> obj-y += $(patsubst %,%.gen.o, $(fw-external-y))
> obj-$(CONFIG_FIRMWARE_IN_KERNEL) += $(patsubst %,%.gen.o, $(fw-shipped-y))
>
> +ifeq ($(KBUILD_SRC),)
> +# Makefile.build only creates subdirectories for O= builds, but external
> +# firmware might live outside the kernel source tree
> +_dummy := $(foreach d,$(addprefix $(obj)/,$(dir $(fw-external-y))), $(shell [ -d $(d) ] || mkdir -p $(d)))
> +endif
> +
> # Remove .S files and binaries created from ihex
> # (during 'make clean' .config isn't included so they're all in $(fw-shipped-))
> targets := $(fw-shipped-) $(patsubst $(obj)/%,%, \
> --
> 1.8.4.5
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-07-08 18:03 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-18 8:46 Regression: firmware: Simplify directory creation + b43 = fails to build Ronald
2014-06-18 14:33 ` Michal Marek
2014-06-18 16:25 ` Ronald
2014-07-07 19:02 ` Torsten Kaiser
2014-07-08 12:09 ` Michal Marek
2014-07-08 12:47 ` [PATCH] firmware: Create directories for external firmware Michal Marek
[not found] ` <CAF1_xX19AwepGJLJOcn_m+OaU3kk9N9d+M2v_YzzPg-M2cdrPQ@mail.gmail.com>
2014-07-08 15:19 ` Ronald
2014-07-08 16:29 ` Ronald
2014-07-08 18:03 ` Torsten Kaiser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox