From: Michal Marek <mmarek@suse.cz>
To: Jan Beulich <JBeulich@suse.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: firmware: fix build of external firmware
Date: Fri, 08 Aug 2014 15:20:33 +0200 [thread overview]
Message-ID: <53E4CEA1.8090207@suse.cz> (raw)
In-Reply-To: <53E34DDC020000780002A045@mail.emea.novell.com>
On 2014-08-07 09:58, Jan Beulich wrote:
> It looks like commit 5180d5f483 ("firmware: Simplify directory
> creation") uncovered a latent bug: The cmd_fwbin make macro, which is
> being called without any arguments, referenced argument 2, which I
> suppose previously just happened to be set to the right value (from an
> enclosing macro invocation - some make versions don't always properly
> clear unused macro arguments on nested macro invocations). In 3.16 with
> such make versions it now points into the source tree instead,
> resulting in build failure when building outside the source tree. And
> obviously on make versions properly clearing unused arguments it would
> have resolved to empty.
With which make version are you seeing the error?
Thanks,
Michal
next prev parent reply other threads:[~2014-08-08 13:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 7:58 firmware: fix build of external firmware Jan Beulich
2014-08-08 13:20 ` Michal Marek [this message]
2014-08-08 13:29 ` Jan Beulich
2014-08-13 14:55 ` Michal Marek
2014-08-22 14:52 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E4CEA1.8090207@suse.cz \
--to=mmarek@suse.cz \
--cc=JBeulich@suse.com \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox