Re: [RFC] [PATCH] kconfig: menuconfig: pkg-config should base upon default configuration

Michal Marek
2014-08-22T11:07:18Z

Dne 11.8.2014 16:22, Silvio Fricke napsal(a):
> Since fc9c6e0 "menuconfig: optionally use pkg-config to detect ncurses
> libs" we use pkg-config, but some cross toolchains (like yocto tc)
> change the search pathes for pc files with some PKG_CONFIG_* environment
> variables.
>
> With this patch we ensure that we only get the host config options for
> ncurses and don't mix with others not relevant settings.
>
> Signed-off-by: Silvio Fricke <silvio.fricke@gmail.com>
> ---
> scripts/kconfig/lxdialog/check-lxdialog.sh | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
> index 9d2a4c5..a067d3c 100644
> --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> @@ -1,6 +1,9 @@
> #!/bin/sh
> # Check ncurses compatibility
>
> +unset PKG_CONFIG_PATH
> +unset PKG_CONFIG_SYSROOT_DIR

PKG_CONFIG_SYSROOT_DIR is clearly meant for cross-compiling and we are
never cross-compiling kconfig. However, PKG_CONFIG_PATH has valid use
cases even when not cross-compiling. Which variables exactly does yocto set?

It might also be a good idea for yocto to special case the kernel and do
not set the variables, because we are not cross-compiling any userspace
programs.

Michal