Re: [PATCH] kbuild: Make scripts executable

Masahiro Yamada
2014-08-21T03:25:32Z

Hi Michal,

On Wed, 20 Aug 2014 16:10:48 +0200
Michal Marek <mmarek@suse.cz> wrote:

> The Makefiles call the respective interpreter explicitly, but this makes
> it easier to use the scripts manually.
>
> Signed-off-by: Michal Marek <mmarek@suse.cz>

I am not sure at all, but
it seems scripts/checkpatch.pl has a rule
to ban execute permissions.

# Check for incorrect file permissions
if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
my $permhere = $here . "FILE: $realfile\n";
if ($realfile !~ m@scripts/@ &&
$realfile !~ /\.(py|pl|awk|sh)$/) {
ERROR("EXECUTE_PERMISSIONS",
"do not set execute permissions for source files\n" . $permhere);
}
}

Best Regards
Masahiro Yamada