* Re: [PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly [not found] <53EA99C3.90203@gmail.com> @ 2014-08-13 8:03 ` Geert Uytterhoeven 2014-08-13 8:16 ` Chen Gang 2014-08-22 11:09 ` Michal Marek 0 siblings, 2 replies; 4+ messages in thread From: Geert Uytterhoeven @ 2014-08-13 8:03 UTC (permalink / raw) To: Chen Gang Cc: Arnd Bergmann, Andrew Morton, Jean Delvare, Russell King, Catalin Marinas, Will Deacon, Mark Salter, a-jacquiot@ti.com, Tony Luck, Fenghua Yu, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, the arch/x86 maintainers, linux-arm-kernel@lists.infradead.org, linux-c6x-dev, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-Arch, linux-kbuild CC kbuild On Wed, Aug 13, 2014 at 12:48 AM, Chen Gang <gang.chen.5i5j@gmail.com> wrote: > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index c49a775..0510a5d 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -199,6 +199,11 @@ config NEED_DMA_MAP_STATE > config ARCH_SUPPORTS_UPROBES > def_bool y > > +config CPU_LITTLE_ENDIAN > + depends on !CPU_BIG_ENDIAN > + def_bool y > + > + > config ARCH_HAS_DMA_SET_COHERENT_MASK > bool As this is a common symbol, and replicated for all affected architectures, I'm wondering if we should have the "config CPU_LITTLE_ENDIAN" in common Kconfig code instead, and make the individual architectures do a "select CPU_LITTLE_ENDIAN"? Also we could have "config CPU_BIG_ENDIAN", too, and error out if none or both are selected (can Kconfig error out?). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly 2014-08-13 8:03 ` [PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly Geert Uytterhoeven @ 2014-08-13 8:16 ` Chen Gang 2014-08-22 11:09 ` Michal Marek 1 sibling, 0 replies; 4+ messages in thread From: Chen Gang @ 2014-08-13 8:16 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Arnd Bergmann, Andrew Morton, Jean Delvare, Russell King, Catalin Marinas, Will Deacon, Mark Salter, a-jacquiot@ti.com, Tony Luck, Fenghua Yu, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, the arch/x86 maintainers, linux-arm-kernel@lists.infradead.org, linux-c6x-dev, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-Arch, linux-kbuild On 8/13/14 16:03, Geert Uytterhoeven wrote: > CC kbuild > > On Wed, Aug 13, 2014 at 12:48 AM, Chen Gang <gang.chen.5i5j@gmail.com> wrote: >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index c49a775..0510a5d 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -199,6 +199,11 @@ config NEED_DMA_MAP_STATE >> config ARCH_SUPPORTS_UPROBES >> def_bool y >> >> +config CPU_LITTLE_ENDIAN >> + depends on !CPU_BIG_ENDIAN >> + def_bool y >> + >> + >> config ARCH_HAS_DMA_SET_COHERENT_MASK >> bool > > As this is a common symbol, and replicated for all affected architectures, > I'm wondering if we should have the "config CPU_LITTLE_ENDIAN" in > common Kconfig code instead, and make the individual architectures do a > "select CPU_LITTLE_ENDIAN"? > That sounds a good idea to me. > Also we could have "config CPU_BIG_ENDIAN", too, and error out > if none or both are selected (can Kconfig error out?). > It is a good idea to me, welcome any members ideas, especially Kbuild members' ideas, suggestions or completions. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly 2014-08-13 8:03 ` [PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly Geert Uytterhoeven 2014-08-13 8:16 ` Chen Gang @ 2014-08-22 11:09 ` Michal Marek 2014-08-23 2:31 ` Chen Gang 1 sibling, 1 reply; 4+ messages in thread From: Michal Marek @ 2014-08-22 11:09 UTC (permalink / raw) To: Geert Uytterhoeven, Chen Gang Cc: Arnd Bergmann, Andrew Morton, Jean Delvare, Russell King, Catalin Marinas, Will Deacon, Mark Salter, a-jacquiot@ti.com, Tony Luck, Fenghua Yu, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, the arch/x86 maintainers, linux-arm-kernel@lists.infradead.org, linux-c6x-dev, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-Arch, linux-kbuild Dne 13.8.2014 10:03, Geert Uytterhoeven napsal(a): > CC kbuild > > On Wed, Aug 13, 2014 at 12:48 AM, Chen Gang <gang.chen.5i5j@gmail.com> wrote: >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index c49a775..0510a5d 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -199,6 +199,11 @@ config NEED_DMA_MAP_STATE >> config ARCH_SUPPORTS_UPROBES >> def_bool y >> >> +config CPU_LITTLE_ENDIAN >> + depends on !CPU_BIG_ENDIAN >> + def_bool y >> + >> + >> config ARCH_HAS_DMA_SET_COHERENT_MASK >> bool > > As this is a common symbol, and replicated for all affected architectures, > I'm wondering if we should have the "config CPU_LITTLE_ENDIAN" in > common Kconfig code instead, and make the individual architectures do a > "select CPU_LITTLE_ENDIAN"? Yes! > Also we could have "config CPU_BIG_ENDIAN", too, and error out > if none or both are selected (can Kconfig error out?). We can error out in the Makefile, if there is consensus that we should be doing so. Michal ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly 2014-08-22 11:09 ` Michal Marek @ 2014-08-23 2:31 ` Chen Gang 0 siblings, 0 replies; 4+ messages in thread From: Chen Gang @ 2014-08-23 2:31 UTC (permalink / raw) To: Michal Marek, Geert Uytterhoeven Cc: Arnd Bergmann, Andrew Morton, Jean Delvare, Russell King, Catalin Marinas, Will Deacon, Mark Salter, a-jacquiot@ti.com, Tony Luck, Fenghua Yu, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, the arch/x86 maintainers, linux-arm-kernel@lists.infradead.org, linux-c6x-dev, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-Arch, linux-kbuild On 8/22/14 19:09, Michal Marek wrote: > Dne 13.8.2014 10:03, Geert Uytterhoeven napsal(a): >> CC kbuild >> >> On Wed, Aug 13, 2014 at 12:48 AM, Chen Gang <gang.chen.5i5j@gmail.com> wrote: >>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >>> index c49a775..0510a5d 100644 >>> --- a/arch/arm/Kconfig >>> +++ b/arch/arm/Kconfig >>> @@ -199,6 +199,11 @@ config NEED_DMA_MAP_STATE >>> config ARCH_SUPPORTS_UPROBES >>> def_bool y >>> >>> +config CPU_LITTLE_ENDIAN >>> + depends on !CPU_BIG_ENDIAN >>> + def_bool y >>> + >>> + >>> config ARCH_HAS_DMA_SET_COHERENT_MASK >>> bool >> >> As this is a common symbol, and replicated for all affected architectures, >> I'm wondering if we should have the "config CPU_LITTLE_ENDIAN" in >> common Kconfig code instead, and make the individual architectures do a >> "select CPU_LITTLE_ENDIAN"? > > Yes! > > >> Also we could have "config CPU_BIG_ENDIAN", too, and error out >> if none or both are selected (can Kconfig error out?). > > We can error out in the Makefile, if there is consensus that we should > be doing so. > OK, thanks. I have sent patch v3 for it, and did not check related error in Kconfig files. Please check the related patches (excuse me, I send the patch v3 only according to "scripts/maintainers.pl", maybe not cc to you explicitly). Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-23 2:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <53EA99C3.90203@gmail.com>
2014-08-13 8:03 ` [PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly Geert Uytterhoeven
2014-08-13 8:16 ` Chen Gang
2014-08-22 11:09 ` Michal Marek
2014-08-23 2:31 ` Chen Gang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox