* Re: linux-next: build warning after merge of the net tree [not found] <20140918103200.12b79941@canb.auug.org.au> @ 2014-09-18 0:35 ` Randy Dunlap 2014-09-23 14:59 ` Michal Marek 0 siblings, 1 reply; 12+ messages in thread From: Randy Dunlap @ 2014-09-18 0:35 UTC (permalink / raw) To: Stephen Rothwell, David Miller, netdev Cc: linux-next, linux-kernel, linux-kbuild On 09/17/14 17:32, Stephen Rothwell wrote: > Hi all, > > After merging the net tree, today's linux-next build (powerpc > ppc64_defconfig) produced these warnings: > > warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > I have looked into these and don't see why there is a problem. Any help would be appreciated. -- ~Randy ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build warning after merge of the net tree 2014-09-18 0:35 ` linux-next: build warning after merge of the net tree Randy Dunlap @ 2014-09-23 14:59 ` Michal Marek 2014-09-23 15:44 ` [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs Michal Marek 2014-09-23 21:23 ` linux-next: build warning after merge of the net tree Stephen Rothwell 0 siblings, 2 replies; 12+ messages in thread From: Michal Marek @ 2014-09-23 14:59 UTC (permalink / raw) To: Randy Dunlap, Stephen Rothwell, David Miller, netdev Cc: linux-next, linux-kernel, linux-kbuild On 2014-09-18 02:35, Randy Dunlap wrote: > On 09/17/14 17:32, Stephen Rothwell wrote: >> Hi all, >> >> After merging the net tree, today's linux-next build (powerpc >> ppc64_defconfig) produced these warnings: >> >> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) >> > > I have looked into these and don't see why there is a problem. > Any help would be appreciated. This is a side effect of 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET"). Previously, SCSI_FC_ATTRS would select SCSI_NETLINK which would select CONFIG_NET. The above warnings are just a tip of the iceberg, the more serious issue is that ppc64_defconfig is lacking networking support. This is the downside of savedefconfig, because the 'select' implications can disappear over time. Looks like more defconfigs are affected by this: $ grep -rL CONFIG_NET= arch/*/configs/ | xargs grep -l CONFIG_SCSI_FC_ATTRS= arch/ia64/configs/generic_defconfig arch/ia64/configs/gensparse_defconfig arch/mips/configs/ip27_defconfig arch/mips/configs/malta_defconfig arch/mips/configs/rm200_defconfig arch/mips/configs/malta_kvm_guest_defconfig arch/mips/configs/gpr_defconfig arch/mips/configs/jazz_defconfig arch/mips/configs/mtx1_defconfig arch/mips/configs/malta_kvm_defconfig arch/mips/configs/loongson3_defconfig arch/parisc/configs/c8000_defconfig arch/powerpc/configs/pseries_defconfig arch/powerpc/configs/pseries_le_defconfig arch/powerpc/configs/ppc64e_defconfig arch/powerpc/configs/ppc64_defconfig arch/powerpc/configs/pmac32_defconfig arch/sh/configs/sh2007_defconfig arch/sh/configs/sdk7780_defconfig arch/sparc/configs/sparc64_defconfig Michal ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs 2014-09-23 14:59 ` Michal Marek @ 2014-09-23 15:44 ` Michal Marek 2014-09-23 15:44 ` [PATCH 2/5] parisc: " Michal Marek ` (4 more replies) 2014-09-23 21:23 ` linux-next: build warning after merge of the net tree Stephen Rothwell 1 sibling, 5 replies; 12+ messages in thread From: Michal Marek @ 2014-09-23 15:44 UTC (permalink / raw) To: sfr, rdunlap, davem Cc: netdev, linux-next, linux-kernel, linux-kbuild, linux-mips Commit 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET") removed what happened to be the only instance of 'select NET'. Defconfigs that were relying on the select now lack networking support. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: linux-mips@linux-mips.org Signed-off-by: Michal Marek <mmarek@suse.cz> --- arch/mips/configs/gpr_defconfig | 1 + arch/mips/configs/ip27_defconfig | 1 + arch/mips/configs/jazz_defconfig | 1 + arch/mips/configs/loongson3_defconfig | 1 + arch/mips/configs/malta_defconfig | 1 + arch/mips/configs/malta_kvm_defconfig | 1 + arch/mips/configs/malta_kvm_guest_defconfig | 1 + arch/mips/configs/mtx1_defconfig | 1 + arch/mips/configs/rm200_defconfig | 1 + 9 files changed, 9 insertions(+) diff --git a/arch/mips/configs/gpr_defconfig b/arch/mips/configs/gpr_defconfig index 8f219da..e24feb06 100644 --- a/arch/mips/configs/gpr_defconfig +++ b/arch/mips/configs/gpr_defconfig @@ -19,6 +19,7 @@ CONFIG_MODULE_UNLOAD=y # CONFIG_BLK_DEV_BSG is not set CONFIG_PCI=y CONFIG_BINFMT_MISC=m +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_INET=y diff --git a/arch/mips/configs/ip27_defconfig b/arch/mips/configs/ip27_defconfig index cc07560..48e16d9 100644 --- a/arch/mips/configs/ip27_defconfig +++ b/arch/mips/configs/ip27_defconfig @@ -28,6 +28,7 @@ CONFIG_MIPS32_COMPAT=y CONFIG_MIPS32_O32=y CONFIG_MIPS32_N32=y CONFIG_PM=y +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=m diff --git a/arch/mips/configs/jazz_defconfig b/arch/mips/configs/jazz_defconfig index 2575302..4f37a59 100644 --- a/arch/mips/configs/jazz_defconfig +++ b/arch/mips/configs/jazz_defconfig @@ -18,6 +18,7 @@ CONFIG_MODULE_UNLOAD=y CONFIG_MODVERSIONS=y CONFIG_BINFMT_MISC=m CONFIG_PM=y +CONFIG_NET=y CONFIG_PACKET=m CONFIG_UNIX=y CONFIG_NET_KEY=m diff --git a/arch/mips/configs/loongson3_defconfig b/arch/mips/configs/loongson3_defconfig index 4cb787f..1c6191e 100644 --- a/arch/mips/configs/loongson3_defconfig +++ b/arch/mips/configs/loongson3_defconfig @@ -59,6 +59,7 @@ CONFIG_MIPS32_COMPAT=y CONFIG_MIPS32_O32=y CONFIG_MIPS32_N32=y CONFIG_PM_RUNTIME=y +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=y diff --git a/arch/mips/configs/malta_defconfig b/arch/mips/configs/malta_defconfig index e18741e..f57b96d 100644 --- a/arch/mips/configs/malta_defconfig +++ b/arch/mips/configs/malta_defconfig @@ -19,6 +19,7 @@ CONFIG_MODULE_UNLOAD=y CONFIG_MODVERSIONS=y CONFIG_MODULE_SRCVERSION_ALL=y CONFIG_PCI=y +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=m diff --git a/arch/mips/configs/malta_kvm_defconfig b/arch/mips/configs/malta_kvm_defconfig index cf0e01f..d41742d 100644 --- a/arch/mips/configs/malta_kvm_defconfig +++ b/arch/mips/configs/malta_kvm_defconfig @@ -20,6 +20,7 @@ CONFIG_MODULE_UNLOAD=y CONFIG_MODVERSIONS=y CONFIG_MODULE_SRCVERSION_ALL=y CONFIG_PCI=y +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=m diff --git a/arch/mips/configs/malta_kvm_guest_defconfig b/arch/mips/configs/malta_kvm_guest_defconfig index edd9ec9..a7806e8 100644 --- a/arch/mips/configs/malta_kvm_guest_defconfig +++ b/arch/mips/configs/malta_kvm_guest_defconfig @@ -19,6 +19,7 @@ CONFIG_MODULE_UNLOAD=y CONFIG_MODVERSIONS=y CONFIG_MODULE_SRCVERSION_ALL=y CONFIG_PCI=y +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=m diff --git a/arch/mips/configs/mtx1_defconfig b/arch/mips/configs/mtx1_defconfig index d269a53..9b6926d 100644 --- a/arch/mips/configs/mtx1_defconfig +++ b/arch/mips/configs/mtx1_defconfig @@ -27,6 +27,7 @@ CONFIG_PD6729=m CONFIG_I82092=m CONFIG_BINFMT_MISC=m CONFIG_PM=y +CONFIG_NET=y CONFIG_PACKET=m CONFIG_UNIX=y CONFIG_XFRM_USER=m diff --git a/arch/mips/configs/rm200_defconfig b/arch/mips/configs/rm200_defconfig index 29d79ae..db029f4 100644 --- a/arch/mips/configs/rm200_defconfig +++ b/arch/mips/configs/rm200_defconfig @@ -20,6 +20,7 @@ CONFIG_MODVERSIONS=y CONFIG_PCI=y CONFIG_BINFMT_MISC=m CONFIG_PM=y +CONFIG_NET=y CONFIG_PACKET=m CONFIG_UNIX=y CONFIG_NET_KEY=m -- 1.8.4.5 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/5] parisc: Set CONFIG_NET=y in defconfigs 2014-09-23 15:44 ` [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs Michal Marek @ 2014-09-23 15:44 ` Michal Marek 2014-09-23 15:44 ` [PATCH 3/5] powerpc: " Michal Marek ` (3 subsequent siblings) 4 siblings, 0 replies; 12+ messages in thread From: Michal Marek @ 2014-09-23 15:44 UTC (permalink / raw) To: sfr, rdunlap, davem Cc: netdev, linux-next, linux-kernel, linux-kbuild, linux-parisc Commit 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET") removed what happened to be the only instance of 'select NET'. Defconfigs that were relying on the select now lack networking support. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: linux-parisc@vger.kernel.org Signed-off-by: Michal Marek <mmarek@suse.cz> --- arch/parisc/configs/c8000_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/parisc/configs/c8000_defconfig b/arch/parisc/configs/c8000_defconfig index 8249ac9..269c23d 100644 --- a/arch/parisc/configs/c8000_defconfig +++ b/arch/parisc/configs/c8000_defconfig @@ -33,6 +33,7 @@ CONFIG_PCI_LBA=y # CONFIG_PDC_CHASSIS_WARN is not set # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set CONFIG_BINFMT_MISC=m +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=m -- 1.8.4.5 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/5] powerpc: Set CONFIG_NET=y in defconfigs 2014-09-23 15:44 ` [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs Michal Marek 2014-09-23 15:44 ` [PATCH 2/5] parisc: " Michal Marek @ 2014-09-23 15:44 ` Michal Marek 2014-09-23 15:44 ` [PATCH 4/5] sh: " Michal Marek ` (2 subsequent siblings) 4 siblings, 0 replies; 12+ messages in thread From: Michal Marek @ 2014-09-23 15:44 UTC (permalink / raw) To: sfr, rdunlap, davem Cc: netdev, linux-next, linux-kernel, linux-kbuild, linuxppc-dev Commit 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET") removed what happened to be the only instance of 'select NET'. Defconfigs that were relying on the select now lack networking support. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Michal Marek <mmarek@suse.cz> --- arch/powerpc/configs/pmac32_defconfig | 1 + arch/powerpc/configs/ppc64_defconfig | 1 + arch/powerpc/configs/ppc64e_defconfig | 1 + arch/powerpc/configs/pseries_defconfig | 1 + arch/powerpc/configs/pseries_le_defconfig | 1 + 5 files changed, 5 insertions(+) diff --git a/arch/powerpc/configs/pmac32_defconfig b/arch/powerpc/configs/pmac32_defconfig index 553e662..0351b5f 100644 --- a/arch/powerpc/configs/pmac32_defconfig +++ b/arch/powerpc/configs/pmac32_defconfig @@ -31,6 +31,7 @@ CONFIG_HIBERNATION=y CONFIG_APM_EMULATION=y CONFIG_PCCARD=m CONFIG_YENTA=m +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=y diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/ppc64_defconfig index f6c02f8..3651887 100644 --- a/arch/powerpc/configs/ppc64_defconfig +++ b/arch/powerpc/configs/ppc64_defconfig @@ -58,6 +58,7 @@ CONFIG_ELECTRA_CF=y CONFIG_HOTPLUG_PCI=y CONFIG_HOTPLUG_PCI_RPA=m CONFIG_HOTPLUG_PCI_RPA_DLPAR=m +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=m diff --git a/arch/powerpc/configs/ppc64e_defconfig b/arch/powerpc/configs/ppc64e_defconfig index 587f551..c3a3269 100644 --- a/arch/powerpc/configs/ppc64e_defconfig +++ b/arch/powerpc/configs/ppc64e_defconfig @@ -33,6 +33,7 @@ CONFIG_SPARSEMEM_MANUAL=y CONFIG_PCI_MSI=y CONFIG_PCCARD=y CONFIG_HOTPLUG_PCI=y +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=m diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig index 50375f1..dd2a9ca 100644 --- a/arch/powerpc/configs/pseries_defconfig +++ b/arch/powerpc/configs/pseries_defconfig @@ -53,6 +53,7 @@ CONFIG_SCHED_SMT=y CONFIG_HOTPLUG_PCI=y CONFIG_HOTPLUG_PCI_RPA=m CONFIG_HOTPLUG_PCI_RPA_DLPAR=m +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=m diff --git a/arch/powerpc/configs/pseries_le_defconfig b/arch/powerpc/configs/pseries_le_defconfig index 4428ee4..63392f4 100644 --- a/arch/powerpc/configs/pseries_le_defconfig +++ b/arch/powerpc/configs/pseries_le_defconfig @@ -55,6 +55,7 @@ CONFIG_SCHED_SMT=y CONFIG_HOTPLUG_PCI=y CONFIG_HOTPLUG_PCI_RPA=m CONFIG_HOTPLUG_PCI_RPA_DLPAR=m +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=m -- 1.8.4.5 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/5] sh: Set CONFIG_NET=y in defconfigs 2014-09-23 15:44 ` [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs Michal Marek 2014-09-23 15:44 ` [PATCH 2/5] parisc: " Michal Marek 2014-09-23 15:44 ` [PATCH 3/5] powerpc: " Michal Marek @ 2014-09-23 15:44 ` Michal Marek 2014-09-23 15:44 ` [PATCH 5/5] sparc: " Michal Marek 2014-09-23 16:02 ` [PATCH 1/5] mips: " David Miller 4 siblings, 0 replies; 12+ messages in thread From: Michal Marek @ 2014-09-23 15:44 UTC (permalink / raw) To: sfr, rdunlap, davem Cc: netdev, linux-next, linux-kernel, linux-kbuild, linux-sh Commit 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET") removed what happened to be the only instance of 'select NET'. Defconfigs that were relying on the select now lack networking support. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: linux-sh@vger.kernel.org Signed-off-by: Michal Marek <mmarek@suse.cz> --- arch/sh/configs/sdk7780_defconfig | 1 + arch/sh/configs/sh2007_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/sh/configs/sdk7780_defconfig b/arch/sh/configs/sdk7780_defconfig index 6a96b9a..bbd4c22 100644 --- a/arch/sh/configs/sdk7780_defconfig +++ b/arch/sh/configs/sdk7780_defconfig @@ -30,6 +30,7 @@ CONFIG_PCI_DEBUG=y CONFIG_PCCARD=y CONFIG_YENTA=y CONFIG_HOTPLUG_PCI=y +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_INET=y diff --git a/arch/sh/configs/sh2007_defconfig b/arch/sh/configs/sh2007_defconfig index e741b1e..df25ae7 100644 --- a/arch/sh/configs/sh2007_defconfig +++ b/arch/sh/configs/sh2007_defconfig @@ -25,6 +25,7 @@ CONFIG_CMDLINE_OVERWRITE=y CONFIG_CMDLINE="console=ttySC1,115200 ip=dhcp root=/dev/nfs rw nfsroot=/nfs/rootfs,rsize=1024,wsize=1024 earlyprintk=sh-sci.1" CONFIG_PCCARD=y CONFIG_BINFMT_MISC=y +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=y -- 1.8.4.5 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 5/5] sparc: Set CONFIG_NET=y in defconfigs 2014-09-23 15:44 ` [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs Michal Marek ` (2 preceding siblings ...) 2014-09-23 15:44 ` [PATCH 4/5] sh: " Michal Marek @ 2014-09-23 15:44 ` Michal Marek 2014-09-23 16:02 ` [PATCH 1/5] mips: " David Miller 4 siblings, 0 replies; 12+ messages in thread From: Michal Marek @ 2014-09-23 15:44 UTC (permalink / raw) To: sfr, rdunlap, davem Cc: netdev, linux-next, linux-kernel, linux-kbuild, sparclinux Commit 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET") removed what happened to be the only instance of 'select NET'. Defconfigs that were relying on the select now lack networking support. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: sparclinux@vger.kernel.org Signed-off-by: Michal Marek <mmarek@suse.cz> --- arch/sparc/configs/sparc64_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sparc/configs/sparc64_defconfig b/arch/sparc/configs/sparc64_defconfig index 9d8521b..6b68f12 100644 --- a/arch/sparc/configs/sparc64_defconfig +++ b/arch/sparc/configs/sparc64_defconfig @@ -29,6 +29,7 @@ CONFIG_PCI=y CONFIG_PCI_MSI=y CONFIG_SUN_OPENPROMFS=m CONFIG_BINFMT_MISC=m +CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y CONFIG_XFRM_USER=m -- 1.8.4.5 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs 2014-09-23 15:44 ` [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs Michal Marek ` (3 preceding siblings ...) 2014-09-23 15:44 ` [PATCH 5/5] sparc: " Michal Marek @ 2014-09-23 16:02 ` David Miller 2014-09-23 16:06 ` Michal Marek 4 siblings, 1 reply; 12+ messages in thread From: David Miller @ 2014-09-23 16:02 UTC (permalink / raw) To: mmarek Cc: sfr, rdunlap, netdev, linux-next, linux-kernel, linux-kbuild, linux-mips From: Michal Marek <mmarek@suse.cz> Date: Tue, 23 Sep 2014 17:44:00 +0200 > Commit 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET > instead of selecting NET") removed what happened to be the only instance > of 'select NET'. Defconfigs that were relying on the select now lack > networking support. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Cc: linux-mips@linux-mips.org > Signed-off-by: Michal Marek <mmarek@suse.cz> On the contrary, since NET was being selected for them indirectly previously, weren't they depending instead upon NET being enabled? Likewise for SCSI_NETLINK, SCSI_FC_ATTRS, and whatever was triggering the select upon them? I'll remember this as yet another why 'select' is to be avoided at just about all costs. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs 2014-09-23 16:02 ` [PATCH 1/5] mips: " David Miller @ 2014-09-23 16:06 ` Michal Marek 0 siblings, 0 replies; 12+ messages in thread From: Michal Marek @ 2014-09-23 16:06 UTC (permalink / raw) To: David Miller Cc: sfr, rdunlap, netdev, linux-next, linux-kernel, linux-kbuild, linux-mips On 2014-09-23 18:02, David Miller wrote: > From: Michal Marek <mmarek@suse.cz> > Date: Tue, 23 Sep 2014 17:44:00 +0200 > >> Commit 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK dependent on NET >> instead of selecting NET") removed what happened to be the only instance >> of 'select NET'. Defconfigs that were relying on the select now lack >> networking support. >> >> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> >> Cc: linux-mips@linux-mips.org >> Signed-off-by: Michal Marek <mmarek@suse.cz> > > On the contrary, since NET was being selected for them indirectly > previously, weren't they depending instead upon NET being enabled? > > Likewise for SCSI_NETLINK, SCSI_FC_ATTRS, and whatever was triggering > the select upon them? They have SCSI_FC_ATTRS=y/m and were relying on the select statements turning this into SCSI_NETLINK=y and CONFIG_NET=y. Michal ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build warning after merge of the net tree 2014-09-23 14:59 ` Michal Marek 2014-09-23 15:44 ` [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs Michal Marek @ 2014-09-23 21:23 ` Stephen Rothwell 2014-09-24 0:36 ` Stephen Rothwell 2014-09-24 1:58 ` David Miller 1 sibling, 2 replies; 12+ messages in thread From: Stephen Rothwell @ 2014-09-23 21:23 UTC (permalink / raw) To: Michal Marek Cc: Randy Dunlap, David Miller, netdev, linux-next, linux-kernel, linux-kbuild, Linus [-- Attachment #1: Type: text/plain, Size: 3334 bytes --] Hi all, On Tue, 23 Sep 2014 16:59:59 +0200 Michal Marek <mmarek@suse.cz> wrote: > > On 2014-09-18 02:35, Randy Dunlap wrote: > > On 09/17/14 17:32, Stephen Rothwell wrote: > >> Hi all, > >> > >> After merging the net tree, today's linux-next build (powerpc > >> ppc64_defconfig) produced these warnings: > >> > >> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > >> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > >> > > > > I have looked into these and don't see why there is a problem. > > Any help would be appreciated. > > This is a side effect of 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK > dependent on NET instead of selecting NET"). Previously, SCSI_FC_ATTRS > would select SCSI_NETLINK which would select CONFIG_NET. The above > warnings are just a tip of the iceberg, the more serious issue is that > ppc64_defconfig is lacking networking support. This is the downside of > savedefconfig, because the 'select' implications can disappear over > time. Looks like more defconfigs are affected by this: And since 5d6be6a5 is now in Linus' tree, we need Michal's 5 patches (at least) to be sent to Linus ASAP ... So it appears that using select can get us into the same sort of trouble that not including all needed header files can. Unfortunately, savedconfig makes that much worse :-(. So anyone changing a "select X" to "depends on X" needs to regenerate a lot of defconfigs to make sure that there are no unforeseen consequences. Dave, this is a bit slack of you since I reported that problem a week ago in the net tree and yet it has not been completely fixed before you asked Linus to pull your tree :-( -- Cheers, Stephen Rothwell sfr@canb.auug.org.au [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build warning after merge of the net tree 2014-09-23 21:23 ` linux-next: build warning after merge of the net tree Stephen Rothwell @ 2014-09-24 0:36 ` Stephen Rothwell 2014-09-24 1:58 ` David Miller 1 sibling, 0 replies; 12+ messages in thread From: Stephen Rothwell @ 2014-09-24 0:36 UTC (permalink / raw) To: Michal Marek Cc: Randy Dunlap, David Miller, netdev, linux-next, linux-kernel, linux-kbuild, Linus [-- Attachment #1: Type: text/plain, Size: 3034 bytes --] Hi all, On Wed, 24 Sep 2014 07:23:06 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Tue, 23 Sep 2014 16:59:59 +0200 Michal Marek <mmarek@suse.cz> wrote: > > > > On 2014-09-18 02:35, Randy Dunlap wrote: > > > On 09/17/14 17:32, Stephen Rothwell wrote: > > >> Hi all, > > >> > > >> After merging the net tree, today's linux-next build (powerpc > > >> ppc64_defconfig) produced these warnings: > > >> > > >> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && CANYONLANDS && GLACIER && 440EP && 440EPX && 440GRX && 440GP && 440GX && 460SX && 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && BLUESTONE && CANYONLANDS && GLACIER && EIGER && 440EPX && 440GRX && 440GX && 460SX && 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && 440GX && 460EX && 460SX && APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > > >> warning: (PPC_CELL_NATIVE && AKEBONO && 440EPX && 440GRX && 440GX && 440SPe && 460EX && 460SX && APM821xx && 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES && ETHERNET && NET_VENDOR_IBM) > > >> > > > > > > I have looked into these and don't see why there is a problem. > > > Any help would be appreciated. > > > > This is a side effect of 5d6be6a5 ("scsi_netlink : Make SCSI_NETLINK > > dependent on NET instead of selecting NET"). Previously, SCSI_FC_ATTRS > > would select SCSI_NETLINK which would select CONFIG_NET. The above > > warnings are just a tip of the iceberg, the more serious issue is that > > ppc64_defconfig is lacking networking support. This is the downside of > > savedefconfig, because the 'select' implications can disappear over > > time. Looks like more defconfigs are affected by this: > > And since 5d6be6a5 is now in Linus' tree, we need Michal's 5 patches > (at least) to be sent to Linus ASAP ... I have put those 5 patches in my fixes tree for today ... -- Cheers, Stephen Rothwell sfr@canb.auug.org.au [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build warning after merge of the net tree 2014-09-23 21:23 ` linux-next: build warning after merge of the net tree Stephen Rothwell 2014-09-24 0:36 ` Stephen Rothwell @ 2014-09-24 1:58 ` David Miller 1 sibling, 0 replies; 12+ messages in thread From: David Miller @ 2014-09-24 1:58 UTC (permalink / raw) To: sfr Cc: mmarek, rdunlap, netdev, linux-next, linux-kernel, linux-kbuild, torvalds From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Wed, 24 Sep 2014 07:23:06 +1000 > Dave, this is a bit slack of you since I reported that problem a week > ago in the net tree and yet it has not been completely fixed before you > asked Linus to pull your tree :-( There were build failures I saw due to some misbalanced select/depends issues which I fixed in: commit df568d8e5250bf24e38c69ad4374baf0f8d279ba Author: David S. Miller <davem@davemloft.net> Date: Mon Sep 22 13:14:33 2014 -0400 scsi: Use 'depends' with LIBFC instead of 'select'. which went in yesterday. I thought that would resolve all of your problems. Believe me, it is a tragic surprise that several defconfigs absolutely depended upon this broken usage of select in the scsi layer, to of all things make CONFIG_NET=y implicit. I'll do my best to sort this out, but I hope that this short term pain is worth it in the end. Thanks for your understanding. ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-09-24 1:59 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140918103200.12b79941@canb.auug.org.au>
2014-09-18 0:35 ` linux-next: build warning after merge of the net tree Randy Dunlap
2014-09-23 14:59 ` Michal Marek
2014-09-23 15:44 ` [PATCH 1/5] mips: Set CONFIG_NET=y in defconfigs Michal Marek
2014-09-23 15:44 ` [PATCH 2/5] parisc: " Michal Marek
2014-09-23 15:44 ` [PATCH 3/5] powerpc: " Michal Marek
2014-09-23 15:44 ` [PATCH 4/5] sh: " Michal Marek
2014-09-23 15:44 ` [PATCH 5/5] sparc: " Michal Marek
2014-09-23 16:02 ` [PATCH 1/5] mips: " David Miller
2014-09-23 16:06 ` Michal Marek
2014-09-23 21:23 ` linux-next: build warning after merge of the net tree Stephen Rothwell
2014-09-24 0:36 ` Stephen Rothwell
2014-09-24 1:58 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox