From: Michal Marek <mmarek@suse.cz>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Valentin Rothberg <valentinrothberg@gmail.com>,
akpm@linux-foundation.org,
Stefan Hengelein <stefan.hengelein@fau.de>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7] checkkconfigsymbols.sh: reimplementation in python
Date: Mon, 29 Sep 2014 16:47:56 +0200 [thread overview]
Message-ID: <5429711C.4060008@suse.cz> (raw)
In-Reply-To: <1411986525.6334.32.camel@x220>
On 2014-09-29 12:28, Paul Bolle wrote:
>> +STMT = r"^\s*(?:if|select|depends\s+on)\s+" + EXPR
>
> Could please make that "depends on"? Yes, it seems the yacc grammar
> accepts any amount of whitespace, but that doesn't make it right to use
> anything other than a single space.
But then lines that violate coding style would not be checked for real
errors.
> (Can the yacc grammar be tweaked to
> see "depends on" as one, well, token?)
I don't think this is a good idea. This is a style issue, why make it a
grammar issue.
Michal
next prev parent reply other threads:[~2014-09-29 14:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1411222524-7850-1-git-send-email-valentinrothberg@gmail.com>
[not found] ` <1411919729-5800-1-git-send-email-valentinrothberg@gmail.com>
2014-09-29 10:28 ` [PATCH v7] checkkconfigsymbols.sh: reimplementation in python Paul Bolle
2014-09-29 12:08 ` Valentin Rothberg
2014-09-29 12:45 ` Paul Bolle
2014-09-29 14:47 ` Michal Marek [this message]
2014-09-29 16:21 ` Paul Bolle
2014-09-29 17:05 ` [PATCH v8] " Valentin Rothberg
2014-10-01 14:58 ` Michal Marek
2014-10-04 9:29 ` Valentin Rothberg
2014-10-08 13:39 ` Michal Marek
2014-10-19 15:30 ` Valentin Rothberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5429711C.4060008@suse.cz \
--to=mmarek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=stefan.hengelein@fau.de \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox