public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: yann.morin.1998@free.fr, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 2/2] kconfig: allow use of relations other than (in)equality
Date: Tue, 04 Nov 2014 14:15:04 +0000	[thread overview]
Message-ID: <5458ED780200007800044DAA@mail.emea.novell.com> (raw)
In-Reply-To: <1415107695.20372.153.camel@x220>

>>> On 04.11.14 at 14:28, <pebolle@tiscali.nl> wrote:
> On Tue, 2014-11-04 at 13:20 +0000, Jan Beulich wrote:
>> >> +	if (k1 == k_string || k2 == k_string)
>> >> +		res = strcmp(str1, str2);
>> >> +	else if (k1 == k_invalid || k2 == k_invalid) {
>> >> +		if (e->type != E_EQUAL && e->type != E_UNEQUAL) {
>> >> +			printf("Cannot compare \"%s\" and \"%s\"\n", str1, str2);
>> >> +printf("(%s -> %d, %s -> %d)\n", sym_type_name(e->left.sym->type), k1, 
>> > sym_type_name(e->right.sym->type), k2);//temp
>> > 
>> > Leftover from development?
>> 
>> Argh - yes, definitely; I even have a note in the patch that these
>> should get dropped, but I managed to ignore that note.
> 
> If all you have to change is drop those three lines, I'll play with this
> patch anyway, as I finally maltreated it enough to apply on top of my
> local changes.

Yes, unless other comments require me to make further changes,
this is all I currently see needing adjustment and re-sending.

Jan


      reply	other threads:[~2014-11-04 14:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04  9:06 [PATCH 2/2] kconfig: allow use of relations other than (in)equality Jan Beulich
2014-11-04 13:14 ` Paul Bolle
2014-11-04 13:20   ` Jan Beulich
2014-11-04 13:28     ` Paul Bolle
2014-11-04 14:15       ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5458ED780200007800044DAA@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox