From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kbuild-owner@vger.kernel.org>
Received: from mail.emea.novell.com ([130.57.118.101]:58117 "EHLO
	mail.emea.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751738AbaKFKTt convert rfc822-to-8bit (ORCPT
	<rfc822;groupwise-linux-kbuild@vger.kernel.org:3:1>);
	Thu, 6 Nov 2014 05:19:49 -0500
Message-Id: <545B59540200007800045446@mail.emea.novell.com>
Date: Thu, 06 Nov 2014 10:19:48 +0000
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH 1/2] kconfig: don't silently ignore unhandled
 characters
References: <5458A4FC0200007800044AC1@mail.emea.novell.com>
 <1415110006.20372.165.camel@x220>
 <5458ED470200007800044DA7@mail.emea.novell.com>
 <1415183789.20372.243.camel@x220>
In-Reply-To: <1415183789.20372.243.camel@x220>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kbuild-owner@vger.kernel.org
List-ID: <linux-kbuild.vger.kernel.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: yann.morin.1998@free.fr, linux-kbuild@vger.kernel.org

>>> On 05.11.14 at 11:36, <pebolle@tiscali.nl> wrote:
> On Tue, 2014-11-04 at 14:14 +0000, Jan Beulich wrote:
>> I think it should stay, even if my flex version may be slightly different
>> from the one that was used originally. As above - it's simply a result
>> of re-generating.
> 
> (This annoyed me enough to dive a bit deeper. This message is mainly to
> archive my notes publicly.)
> 
> This #define was added in v3.1. See commit 2f76b358f9fb ("kconfig: regen
> parser"). Commit explanations were probably a bit expensive then since
> this is all the info we have: we don't know why this was done, nor how
> (which program, which options, etc.).
> 
> Anyhow, I don't think ECHO is used anywhere. grepping for ECHO in
> scripts/ finds dtc-lexer.lex.c_shipped, lex.lex.c_shipped, and this
> file. In the other two _shipped files ECHO is actually used. So,
> apparently it's not a bit of lex magic. The #define might as well be
> removed.

Again - this is code that gets generated by flex, and hence
dropping it (entirely, or the hunk that changes it) will make the
discussion re-appear the next time someone re-generates the
file.

Jan