public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kconfig: fix build warning
@ 2014-11-29 17:23 Luka Perkov
  2014-12-01 14:32 ` Michal Marek
  0 siblings, 1 reply; 2+ messages in thread
From: Luka Perkov @ 2014-11-29 17:23 UTC (permalink / raw)
  To: linux-kbuild; +Cc: yann.morin.1998, Luka Perkov

Patch fixes following build warning:

In file included from scripts/kconfig/zconf.tab.c:2537:0:
scripts/kconfig/menu.c: In function ‘get_symbol_str’:
scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     jump->offset = strlen(r->s);
                  ^
scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here
  struct jump_key *jump;

Signed-off-by: Luka Perkov <luka.perkov@sartura.hr>
---
 scripts/kconfig/menu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index a26cc5d..584e0fc 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
 {
 	int i, j;
 	struct menu *submenu[8], *menu, *location = NULL;
-	struct jump_key *jump;
+	struct jump_key *jump = NULL;
 
 	str_printf(r, _("Prompt: %s\n"), _(prop->text));
 	menu = prop->menu->parent;
-- 
2.1.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] kconfig: fix build warning
  2014-11-29 17:23 [PATCH] kconfig: fix build warning Luka Perkov
@ 2014-12-01 14:32 ` Michal Marek
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2014-12-01 14:32 UTC (permalink / raw)
  To: Luka Perkov, linux-kbuild; +Cc: yann.morin.1998

On 2014-11-29 18:23, Luka Perkov wrote:
> Patch fixes following build warning:
> 
> In file included from scripts/kconfig/zconf.tab.c:2537:0:
> scripts/kconfig/menu.c: In function ‘get_symbol_str’:
> scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>      jump->offset = strlen(r->s);
>                   ^
> scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here
>   struct jump_key *jump;
> 
> Signed-off-by: Luka Perkov <luka.perkov@sartura.hr>

Thanks for the patch, but a similar one has already been merged to
kbuild.git and linux-next.git.

Michal


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-01 14:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-29 17:23 [PATCH] kconfig: fix build warning Luka Perkov
2014-12-01 14:32 ` Michal Marek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox