From: Shuah Khan <shuahkh@osg.samsung.com>
To: Michael Ellerman <mpe@ellerman.id.au>, linux-kernel@vger.kernel.org
Cc: mmarek@suse.cz, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, rostedt@goodmis.org, mingo@redhat.com,
davem@davemloft.net, keescook@chromium.org,
tranmanphong@gmail.com, cov@codeaurora.org,
dh.herrmann@gmail.com, hughd@google.com, bobby.prani@gmail.com,
serge.hallyn@ubuntu.com, ebiederm@xmission.com,
tim.bird@sonymobile.com, josh@joshtriplett.org, koct9i@gmail.com,
linux-kbuild@vger.kernel.org, linux-api@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 4/6] kbuild: add a new kselftest_install make target to install selftests
Date: Fri, 16 Jan 2015 09:34:41 -0700 [thread overview]
Message-ID: <54B93DA1.2010601@osg.samsung.com> (raw)
In-Reply-To: <1420794375-31881-4-git-send-email-mpe@ellerman.id.au>
On 01/09/2015 02:06 AM, Michael Ellerman wrote:
> Add a new make target to install kernel selftests. This new target will
> build and install selftests.
>
> The default is just $(objtree)/selftests. This is preferable to
> something based on $(INSTALL_MOD_PATH) (which defaults to /), as it
> allows a normal user to install the tests. This is similar to the
> default behaviour of make headers_install.
A normal user can install tests at any location they choose by
overriding the default path. For example:
INSTALL_MOD_PATH=/tmp make kselftest_install
will install under tmp.
The approach I used also ties test installs to kernel release.
This addresses an important use-case for kernel developers
that want to compare results from release to release.
The use-case for any user to be able to install tests at
any location is addressed by the above example.
I would like these two above use-cases continued to be supported,
especially the one that tries the test installs to kernel release.
Another goal is to keep changes to the main Makefile minimal and
the rest of the install support belongs under selftests/Makefile
and any other include file (like the one you proposed).
The patch I have in patch v4 addresses the use-cases mentioned above.
I do like the lib.mk approach in general and I am going to review that
patch and give you feedback.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-01-16 16:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 9:06 [PATCH 1/6] selftests: Introduce minimal shared logic for running tests Michael Ellerman
2015-01-09 9:06 ` [PATCH 2/6] selftests: Add install target Michael Ellerman
2015-01-16 17:46 ` Shuah Khan
2015-01-19 0:35 ` Michael Ellerman
2015-01-19 16:35 ` Shuah Khan
2015-01-20 3:13 ` Michael Ellerman
2015-01-09 9:06 ` [PATCH 3/6] selftests: Add install support for the powerpc tests Michael Ellerman
2015-01-09 9:06 ` [PATCH 4/6] kbuild: add a new kselftest_install make target to install selftests Michael Ellerman
2015-01-16 16:34 ` Shuah Khan [this message]
2015-01-19 0:35 ` Michael Ellerman
2015-01-19 16:34 ` Shuah Khan
2015-01-09 9:06 ` [PATCH 5/6] kbuild: Don't pass -rR to selftest makefiles Michael Ellerman
2015-01-09 9:06 ` [PATCH 6/6] selftests: Set CC using CROSS_COMPILE once in lib.mk Michael Ellerman
2015-01-16 16:37 ` Shuah Khan
2015-01-16 17:53 ` [PATCH 1/6] selftests: Introduce minimal shared logic for running tests Shuah Khan
2015-01-19 0:35 ` Michael Ellerman
2015-01-19 16:39 ` Shuah Khan
2015-01-20 3:08 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B93DA1.2010601@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=cov@codeaurora.org \
--cc=davem@davemloft.net \
--cc=dh.herrmann@gmail.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=koct9i@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=serge.hallyn@ubuntu.com \
--cc=tim.bird@sonymobile.com \
--cc=tranmanphong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox