From: Michal Marek <mmarek@suse.cz>
To: shengyong <shengyong1@huawei.com>
Cc: linux-kbuild@vger.kernel.org, sam@ravnborg.org
Subject: Re: Question: "genksyms: Track changes to enum constants" doesn't work
Date: Thu, 12 Mar 2015 09:17:35 +0100 [thread overview]
Message-ID: <55014B9F.3060602@suse.cz> (raw)
In-Reply-To: <54FFC37C.8030505@huawei.com>
Dne 11.3.2015 v 05:24 shengyong napsal(a):
> Hi, Michal Marek
>
> The commit e37ddb8250 ("genksyms: Track changes to enum constants") helps to changes the
> checksum of export symbol if an enum is changed. I test this agains linux-next, but it
> seems that it does not work well.
>
> #include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/init.h>
>
> enum a {
> E1,
> E2,
> E_MAX
> };
>
> struct s {
> int a[E_MAX];
> };
What you are seeing is the effect of commit 2c5925d ("genksyms: Do not
expand internal types"). You need to move the type definitions to a
header for these to be considered by genksyms.
Michal
prev parent reply other threads:[~2015-03-12 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 4:24 Question: "genksyms: Track changes to enum constants" doesn't work shengyong
2015-03-12 8:17 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55014B9F.3060602@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=shengyong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox