From: Michal Marek <mmarek@suse.cz>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Valdis Kletnieks <Valdis.Kletnieks@vt.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [RFC PATCH] Don't reset timestamps in include/generated if not needed
Date: Fri, 13 Mar 2015 11:00:38 +0100 [thread overview]
Message-ID: <5502B546.5010806@suse.cz> (raw)
In-Reply-To: <CAK7LNASH7oTCcNbyt_D+aaNuG+UFb8MXLUHBMWtW+ZcjmFsnjw@mail.gmail.com>
Dne 13.3.2015 v 05:59 Masahiro Yamada napsal(a):
> 2015-03-11 19:01 GMT+09:00 Michal Marek <mmarek@suse.cz>:
>> We already have it and it is called "filechk." Valdis, can you check if
>> the below patch works equally well for you?
>
> This looks almost nice, but a few comments below.
Thanks for the review!
>> $(obj)/$(bounds-file): kernel/bounds.s Kbuild
>
> You are checking the resulting file content,
> so the dependency on "Kbuild" is not necessary.
>
> Instead, you need to add "FORCE" so that this rule is always invoked.
Good point.
>> $(Q)mkdir -p $(dir $@)
>
> You can drop this line because filechk automatically creates the
> output directory.
Likewise.
Michal
next prev parent reply other threads:[~2015-03-13 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <15447.1425431256@turing-police.cc.vt.edu>
2015-03-08 23:08 ` [RFC PATCH] Don't reset timestamps in include/generated if not needed Linus Torvalds
2015-03-11 10:01 ` Michal Marek
2015-03-13 4:59 ` Masahiro Yamada
2015-03-13 10:00 ` Michal Marek [this message]
2015-03-24 15:36 ` [PATCH] kbuild: " Michal Marek
2015-03-24 16:08 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5502B546.5010806@suse.cz \
--to=mmarek@suse.cz \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox